refactor(ast): move AstBuilder type definition#11238
Merged
graphite-app[bot] merged 1 commit intomainfrom May 24, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #11238 will degrade performances by 12.93%Comparing Summary
Benchmarks breakdown
|
This was referenced May 23, 2025
6bedcef to
ed5c98c
Compare
03d932a to
0b759f3
Compare
Member
Merge activity
|
Pure refactor. Move the type definition out of generated file and define it statically instead. We can now change `AstBuilder` without having to alter the codegen.
ed5c98c to
c2c0268
Compare
0b759f3 to
f05c506
Compare
Base automatically changed from
05-21-feat_syntax_introduce_commentnodeid_
to
main
May 24, 2025 02:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Pure refactor. Move the type definition out of generated file and define it statically instead. We can now change
AstBuilderwithout having to alter the codegen.