Skip to content

refactor(allocator): TakeIn::take_in_box accept any AllocatorAccessor#11216

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-21-refactor_allocator_takein_take_in_box_accept_any_allocatoraccessor_
May 21, 2025
Merged

refactor(allocator): TakeIn::take_in_box accept any AllocatorAccessor#11216
graphite-app[bot] merged 1 commit intomainfrom
05-21-refactor_allocator_takein_take_in_box_accept_any_allocatoraccessor_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 21, 2025

Pure refactor. TakeIn::take_in_box accept any AllocatorAccessor, same as take_in does. This change allows shortening calling code, and improves consistency between the 2 methods.

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-minifier Area - Minifier A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels May 21, 2025
@overlookmotel overlookmotel marked this pull request as ready for review May 21, 2025 11:43
@overlookmotel overlookmotel requested a review from Dunqing as a code owner May 21, 2025 11:43
@codspeed-hq
Copy link

codspeed-hq bot commented May 21, 2025

CodSpeed Instrumentation Performance Report

Merging #11216 will not alter performance

Comparing 05-21-refactor_allocator_takein_take_in_box_accept_any_allocatoraccessor_ (cef5452) with main (3df1bba)

Summary

✅ 38 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label May 21, 2025
Copy link
Member

Boshen commented May 21, 2025

Merge activity

…sor` (#11216)

Pure refactor. `TakeIn::take_in_box` accept any `AllocatorAccessor`, same as `take_in` does. This change allows shortening calling code, and improves consistency between the 2 methods.
@graphite-app graphite-app bot force-pushed the 05-21-refactor_allocator_takein_take_in_box_accept_any_allocatoraccessor_ branch from 9afd44d to cef5452 Compare May 21, 2025 12:29
@graphite-app graphite-app bot merged commit cef5452 into main May 21, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 05-21-refactor_allocator_takein_take_in_box_accept_any_allocatoraccessor_ branch May 21, 2025 12:35
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-minifier Area - Minifier A-transformer Area - Transformer / Transpiler C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants