perf(parser): remove redundant checks#11207
Merged
Boshen merged 2 commits intooxc-project:mainfrom May 21, 2025
Merged
Conversation
CodSpeed Instrumentation Performance ReportMerging #11207 will not alter performanceComparing Summary
|
Contributor
Author
|
Doesn't look like there are any substantial improvements. Feel free to close my PR or pick the changes you want. Two of my three changes are simple removals and make the code simpler. Edit: removed the second change because it's not worth the sacrificed readability |
Member
|
Less code is always 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
is_numberinclass.rscan be removed, becauseis_identifier_or_keywordimpliesis_literal_property_nameimplyingis_numberAvoids checking foris_reserved_keywordone way and then the other way.is_all_keywordinis_identifier_or_keywordcan be removed, becauseis_literal_property_nameimpliesis_identifier_nameimplyingis_all_keywordLet's see if those changes yield any improvements in the benchmark or if the compiler was smart enough to optimize that.
Edit: removed the second change because it's not worth the sacrificed readability