feat(allocator): TakeIn trait with AllocatorAccessor

[Boshen]

closes #10314

[Boshen]

• feat(allocator): TakeIn trait with AllocatorAccessor #11201 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull Request Overview

Adds an AllocatorAccessor trait to abstract over allocator ownership and updates all .take_in(ctx.ast.allocator) calls to use the new generic take_in(ctx.ast) API.

• Introduce AllocatorAccessor trait with implementations for &Allocator and AstBuilder
• Change TakeIn::take_in to accept any AllocatorAccessor instead of a raw &Allocator
• Bulk-update all peephole passes and builders to call take_in(ctx.ast) rather than take_in(ctx.ast.allocator)

Reviewed Changes

Copilot reviewed 50 out of 50 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
crates/oxc_allocator/src/accessor.rs	New trait AllocatorAccessor for allocator access
crates/oxc_allocator/src/take_in.rs	Updated TakeIn::take_in to use AllocatorAccessor
crates/oxc_ast/src/ast_builder_impl.rs	Impl AllocatorAccessor for AstBuilder
All crates/oxc_minifier/src/peephole/*.rs	Replaced .take_in(ctx.ast.allocator) with .take_in(ctx.ast)
crates/oxc_isolated_declarations/src/module.rs	One replacement in isolated declarations module

Comments suppressed due to low confidence (2)

crates/oxc_allocator/src/take_in.rs:8

• [nitpick] Doc comment for the updated take_in method signature should explain that it now takes an AllocatorAccessor rather than a raw &Allocator.

pub trait TakeIn<'a>: Dummy<'a> {

crates/oxc_allocator/src/accessor.rs:9

• [nitpick] Consider adding a small unit test to verify that AllocatorAccessor works correctly with both &Allocator and AstBuilder implementations.

impl<'a> AllocatorAccessor<'a> for &'a Allocator {

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #11201 will degrade performances by 12.71%

_{Comparing 05-20-feat_allocator_takein_trait_with_allocatoraccessor_ (03390ad) with main (23182b8)}

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
❌	mangler[cal.com.tsx]	3 ms	3.5 ms	-12.71%

[graphite-app]

Merge activity

• May 21, 3:13 AM UTC: Boshen added this pull request to the Graphite merge queue.
• May 21, 3:27 AM UTC: Merged by the Graphite merge queue.