fix(allocator/vec): fix unsoundness in Vec::extend_from_slices_copy#11200
Merged
graphite-app[bot] merged 1 commit intomainfrom May 21, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #11200 will not alter performanceComparing Summary
|
Dunqing
approved these changes
May 21, 2025
Member
Merge activity
|
…#11200) Fix a soundness bug in `Vec::extend_from_slices_copy`. Similar to `String::from_strs_array_in`, we have to handle the possibility that the total length of the slices provided could exceed `usize::MAX`. If it did, we could reserve too little capacity, and write out of bounds. Used checked addition to catch this. This bug is present in `bumpalo`, and we inherited it.
graphite-app
bot
force-pushed
the
05-20-refactor_allocator_innervec_use_alloc_trait
branch
from
8937f64 to
6827543
Compare
graphite-app
bot
force-pushed
the
05-20-fix_allocator_vec_fix_unsoundness_in_vec_extend_from_slices_copy_
branch
from
e1ef05f to
250e56f
Compare
Base automatically changed from
05-20-refactor_allocator_innervec_use_alloc_trait
to
main
May 21, 2025 00:50
graphite-app
bot
deleted the
05-20-fix_allocator_vec_fix_unsoundness_in_vec_extend_from_slices_copy_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix a soundness bug in
Vec::extend_from_slices_copy.Similar to
String::from_strs_array_in, we have to handle the possibility that the total length of the slices provided could exceedusize::MAX. If it did, we could reserve too little capacity, and write out of bounds. Used checked addition to catch this.This bug is present in
bumpalo, and we inherited it.