feat(ast/estree): add phase field to ImportExpression in TS-ESTree AST#11193
Merged
graphite-app[bot] merged 1 commit intomainfrom May 21, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-ast
CodSpeed Instrumentation Performance ReportMerging #11193 will not alter performanceComparing Summary
|
overlookmotel
force-pushed
the
05-20-feat_ast_estree_add_phase_field_to_importexpression_in_ts-estree_ast
branch
from
7b8edbc to
ebdca5a
Compare
Member
Merge activity
|
…e AST (#11193) Related to #10978. Add `phase` property to `ImportExpression` in TS-ESTree AST. This aligns with ESTree spec, but does *not* align with TS-ESLint - TS-ESLint outputs a `CallExpression` with a `MetaProperty` as its `callee` instead. We don't have the necessary information in our AST to match TS-ESLint, because we don't have the spans of `import`, `defer`, or `import.defer`, to use for the `MetaProperty`, or the `IdentifierName`s it contains. This is not completely ideal, but I figure it's preferable to represent this syntax *somehow* in the AST, rather than completely ignoring it, in which case there's no way to distinguish between `import("x")`, `import.defer("x")`, and `import.source("x")`. Presumably TS-ESLint will change their AST shape to conform to ESTree spec once these reach stage 4, so I don't think we should expend effort changing our AST to align with them in the meantime. TypeScript doesn't even have test cases for these (we'd know if they did, as we'd be failing them) - so I doubt these are popular constructs in TS. `acorn-test262` submodule is bumped to include oxc-project/estree-conformance#36 which adds the `phase` field to `ImportExpression`s in test snapshots.
graphite-app
bot
force-pushed
the
05-20-feat_ast_estree_add_phase_field_to_importexpression_in_ts-estree_ast
branch
from
ebdca5a to
23182b8
Compare
graphite-app
bot
deleted the
05-20-feat_ast_estree_add_phase_field_to_importexpression_in_ts-estree_ast
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #10978. Add
phaseproperty toImportExpressionin TS-ESTree AST.This aligns with ESTree spec, but does not align with TS-ESLint - TS-ESLint outputs a
CallExpressionwith aMetaPropertyas itscalleeinstead.We don't have the necessary information in our AST to match TS-ESLint, because we don't have the spans of
import,defer, orimport.defer, to use for theMetaProperty, or theIdentifierNames it contains.This is not completely ideal, but I figure it's preferable to represent this syntax somehow in the AST, rather than completely ignoring it, in which case there's no way to distinguish between
import("x"),import.defer("x"), andimport.source("x").Presumably TS-ESLint will change their AST shape to conform to ESTree spec once these reach stage 4, so I don't think we should expend effort changing our AST to align with them in the meantime. TypeScript doesn't even have test cases for these (we'd know if they did, as we'd be failing them) - so I doubt these are popular constructs in TS.
acorn-test262submodule is bumped to include oxc-project/estree-conformance#36 which adds thephasefield toImportExpressions in test snapshots.