Skip to content

fix(parser): fix reading Token flags on big-endian systems#11153

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-19-fix_parser_fix_reading_token_flags_on_big-endian_systems
May 19, 2025
Merged

fix(parser): fix reading Token flags on big-endian systems#11153
graphite-app[bot] merged 1 commit intomainfrom
05-19-fix_parser_fix_reading_token_flags_on_big-endian_systems

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 19, 2025

Fixes #11119.

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-parser Area - Parser C-bug Category - Bug labels May 19, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented May 19, 2025

CodSpeed Instrumentation Performance Report

Merging #11153 will not alter performance

Comparing 05-19-fix_parser_fix_reading_token_flags_on_big-endian_systems (83e4f9b) with main (f8fac4e)

Summary

✅ 38 untouched benchmarks

@overlookmotel overlookmotel marked this pull request as ready for review May 19, 2025 10:37
@overlookmotel
Copy link
Member Author

The fix seems to work. oxc-project/oxc-node#143 tested it.

@overlookmotel overlookmotel marked this pull request as draft May 19, 2025 10:43
@overlookmotel overlookmotel force-pushed the 05-19-fix_parser_fix_reading_token_flags_on_big-endian_systems branch from 4b28dbc to 00fc75b Compare May 19, 2025 10:46
@overlookmotel overlookmotel marked this pull request as ready for review May 19, 2025 10:52
@overlookmotel
Copy link
Member Author

It seems to solve the problem, so merging.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label May 19, 2025
Copy link
Member Author

overlookmotel commented May 19, 2025

Merge activity

@graphite-app graphite-app bot force-pushed the 05-19-fix_parser_fix_reading_token_flags_on_big-endian_systems branch from 00fc75b to 83e4f9b Compare May 19, 2025 10:54
@graphite-app graphite-app bot merged commit 83e4f9b into main May 19, 2025
24 checks passed
@graphite-app graphite-app bot deleted the 05-19-fix_parser_fix_reading_token_flags_on_big-endian_systems branch May 19, 2025 11:00
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

parser: failed to parse on big-endian machines

1 participant