Skip to content

perf(data_structures): inline all methods in PointerExt#11149

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-19-perf_data_structures_inline_all_methods_in_pointerext_
May 19, 2025
Merged

perf(data_structures): inline all methods in PointerExt#11149
graphite-app[bot] merged 1 commit intomainfrom
05-19-perf_data_structures_inline_all_methods_in_pointerext_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 19, 2025

Add #[inline(always)] to one method that I missed.

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-performance Category - Solution not expected to change functional behavior, only performance label May 19, 2025
@overlookmotel overlookmotel marked this pull request as ready for review May 19, 2025 09:35
@overlookmotel
Copy link
Member Author

This was just a small oversight on my part, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label May 19, 2025
Copy link
Member Author

overlookmotel commented May 19, 2025

Merge activity

@codspeed-hq
Copy link

codspeed-hq bot commented May 19, 2025

CodSpeed Instrumentation Performance Report

Merging #11149 will degrade performances by 12.33%

Comparing 05-19-perf_data_structures_inline_all_methods_in_pointerext_ (f8fac4e) with main (a762038)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 3 ms 3.5 ms -12.33%

Add `#[inline(always)]` to one method that I missed.
@graphite-app graphite-app bot force-pushed the 05-19-perf_data_structures_inline_all_methods_in_pointerext_ branch from 36b647e to f8fac4e Compare May 19, 2025 09:44
@graphite-app graphite-app bot merged commit f8fac4e into main May 19, 2025
24 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 19, 2025
@graphite-app graphite-app bot deleted the 05-19-perf_data_structures_inline_all_methods_in_pointerext_ branch May 19, 2025 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant