fix(transformer/legacy-decorator): decorates insertion order is incorrect

[Dunqing]

Insert the decorations early rather than waiting for the class assignment to insert them together. This is to avoid the decorators being inserted before the defineProperty(xxx) which could cause accessing an field still doesn't decorated yet.

Input:

function Bar(): ClassDecorator {
  return (_target) => {
    console.log(Bar.name)
  }
}

@Bar()
class Foo {
  static foo = `${Foo.name}`;
}

Before output:

var _Foo;
function Bar() {
  return (_target) => {
    console.log(Bar.name);
  };
}
let Foo = _Foo = class Foo {};
babelHelpers.defineProperty(Foo, "foo", `${_Foo.name}`);
Foo = _Foo = babelHelpers.decorate([Bar()], Foo);

After output:

var _Foo;
function Bar() {
  return (_target) => {
    console.log(Bar.name);
  };
}
let Foo = _Foo = class Foo {};
Foo = _Foo = babelHelpers.decorate([Bar()], Foo);
babelHelpers.defineProperty(Foo, "foo", `${_Foo.name}`);

[Dunqing]

• fix(transformer/legacy-decorator): decorates insertion order is incorrect #11144 👈 (View in Graphite)
• fix(transformer/legacy-decorator): static class fields cannot be accessed in static field initializer when class-properties plugin is not enabled #11143
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #11144 will degrade performances by 12.4%

_{Comparing 05-19-fix_transformer_legacy-decorator_decorates_insertion_order_is_incorrect (fcd5ba9) with main (f081757)}

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
❌	mangler[cal.com.tsx]	3 ms	3.5 ms	-12.4%

[Boshen]

Merge activity

• May 19, 9:54 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• May 19, 9:49 PM EDT: Boshen added this pull request to the Graphite merge queue.
• May 19, 9:51 PM EDT: Merged by the Graphite merge queue.