Skip to content

refactor(parser): use bump instead of eat if ignoring return value#11137

Merged
overlookmotel merged 1 commit intooxc-project:mainfrom
ulrichstark:prefer-bump-over-eat-if-ignoring-return-value
May 18, 2025
Merged

refactor(parser): use bump instead of eat if ignoring return value#11137
overlookmotel merged 1 commit intooxc-project:mainfrom
ulrichstark:prefer-bump-over-eat-if-ignoring-return-value

Conversation

@ulrichstark
Copy link
Contributor

No description provided.

@github-actions github-actions bot added A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels May 18, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented May 18, 2025

CodSpeed Instrumentation Performance Report

Merging #11137 will degrade performances by 12.54%

Comparing ulrichstark:prefer-bump-over-eat-if-ignoring-return-value (530d75d) with main (1210621)

Summary

❌ 1 regressions
✅ 37 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
mangler[cal.com.tsx] 3 ms 3.4 ms -12.54%

@overlookmotel overlookmotel merged commit 7b9ab22 into oxc-project:main May 18, 2025
23 checks passed
@ulrichstark ulrichstark deleted the prefer-bump-over-eat-if-ignoring-return-value branch May 19, 2025 06:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants