perf(mangler)!: Mangler::build_with_semantic take mut ref to Semantic#11132
Merged
graphite-app[bot] merged 1 commit intomainfrom May 19, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-semantic
CodSpeed Instrumentation Performance ReportMerging #11132 will not alter performanceComparing Summary
Benchmarks breakdown
|
Member
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
May 19, 2025
…tic` (#11132) `Semantic` is a very large type (600 bytes). The mangler only uses a part of it (`Scoping` and `AstNodes`), so it's a waste to copy the whole type onto the stack and then return it again. Change `Mangler::build_with_semantic` to take `&mut Semantic` instead. I hope this may also help a bit with wild variance in mangler benchmarks, as `Semantic` will no longer get dropped in the measured section (I don't think should be part of the measurement anyway, as the drop time of `Semantic` is not relevant in this benchmark).
graphite-app
bot
force-pushed
the
05-18-perf_mangler_mangler_build_with_semantic_take_mut_ref_to_semantic_
branch
from
2469dd0 to
e36b39c
Compare
…tic` (#11132) `Semantic` is a very large type (600 bytes). The mangler only uses a part of it (`Scoping` and `AstNodes`), so it's a waste to copy the whole type onto the stack and then return it again. Change `Mangler::build_with_semantic` to take `&mut Semantic` instead. I hope this may also help a bit with wild variance in mangler benchmarks, as `Semantic` will no longer get dropped in the measured section (I don't think should be part of the measurement anyway, as the drop time of `Semantic` is not relevant in this benchmark).
graphite-app
bot
force-pushed
the
05-18-perf_mangler_mangler_build_with_semantic_take_mut_ref_to_semantic_
branch
from
e36b39c to
65a6419
Compare
graphite-app
bot
deleted the
05-18-perf_mangler_mangler_build_with_semantic_take_mut_ref_to_semantic_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Semanticis a very large type (600 bytes). The mangler only uses a part of it (ScopingandAstNodes), so it's a waste to copy the whole type onto the stack and then return it again.Change
Mangler::build_with_semanticto take&mut Semanticinstead.I hope this may also help a bit with wild variance in mangler benchmarks, as
Semanticwill no longer get dropped in the measured section (I don't think should be part of the measurement anyway, as the drop time ofSemanticis not relevant in this benchmark).