Skip to content

fix(ci): use jsdelivr for all benchmark files#11108

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-18-fix_ci_use_jsdelivr_for_all_benchmark_files
May 18, 2025
Merged

fix(ci): use jsdelivr for all benchmark files#11108
graphite-app[bot] merged 1 commit intomainfrom
05-18-fix_ci_use_jsdelivr_for_all_benchmark_files

Conversation

@Boshen
Copy link
Member

@Boshen Boshen commented May 18, 2025

Copilot AI review requested due to automatic review settings May 18, 2025 04:25
@graphite-app
Copy link
Contributor

graphite-app bot commented May 18, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates benchmark file URLs to use jsdelivr instead of raw GitHub URLs in order to accommodate updated rate limits for unauthenticated requests.

  • Replaced GitHub raw URLs with corresponding jsdelivr URLs in multiple test and benchmark files.
  • Ensured consistency in URL formatting across Rust and TypeScript benchmarks.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
tasks/common/src/test_file.rs Updated TypeScript and React benchmark file URLs to jsdelivr.
tasks/benchmark/benches/isolated_declarations.rs Updated Vue benchmark file URL to jsdelivr.
napi/parser/test/parse-raw.test.ts Updated commented and active benchmark file URLs for consistency.
napi/parser/bench.bench.mjs Updated benchmark file URLs to jsdelivr, ensuring consistency across dependencies.

@github-actions github-actions bot added the C-bug Category - Bug label May 18, 2025
@Boshen Boshen added 0-merge Merge with Graphite Merge Queue and removed C-bug Category - Bug labels May 18, 2025
Copy link
Member Author

Boshen commented May 18, 2025

Merge activity

@Boshen Boshen force-pushed the 05-18-fix_ci_use_jsdelivr_for_all_benchmark_files branch from 0a20b30 to 120418a Compare May 18, 2025 04:25
@github-actions github-actions bot added the C-bug Category - Bug label May 18, 2025
@graphite-app graphite-app bot force-pushed the 05-18-fix_ci_use_jsdelivr_for_all_benchmark_files branch from 120418a to 3795eb6 Compare May 18, 2025 04:33
@codspeed-hq
Copy link

codspeed-hq bot commented May 18, 2025

CodSpeed Instrumentation Performance Report

Merging #11108 will not alter performance

Comparing 05-18-fix_ci_use_jsdelivr_for_all_benchmark_files (3795eb6) with main (6571b9b)

Summary

✅ 36 untouched benchmarks

@graphite-app graphite-app bot merged commit 3795eb6 into main May 18, 2025
25 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 18, 2025
@graphite-app graphite-app bot deleted the 05-18-fix_ci_use_jsdelivr_for_all_benchmark_files branch May 18, 2025 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants