Skip to content

refactor(span): remove source_type module#11024

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-14-refactor_span_remove_source_type_module
May 14, 2025
Merged

refactor(span): remove source_type module#11024
graphite-app[bot] merged 1 commit intomainfrom
05-14-refactor_span_remove_source_type_module

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 14, 2025

It's unnecessary to have a separate errors.rs file for SourceType. Combine 2 files into 1.

Pure refactor. This PR doesn't alter any of the logic, just relocates it.

@github-actions github-actions bot added A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels May 14, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review May 14, 2025 07:31
@codspeed-hq
Copy link

codspeed-hq bot commented May 14, 2025

CodSpeed Instrumentation Performance Report

Merging #11024 will create unknown performance changes

Comparing 05-14-refactor_span_remove_source_type_module (567368e) with main (4a72b58)

Summary

🆕 36 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 22.8 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 67 ms N/A
🆕 formatter[antd.js] N/A 715.8 ms N/A
🆕 formatter[react.development.js] N/A 8 ms N/A
🆕 formatter[typescript.js] N/A 1.1 s N/A
🆕 isolated-declarations[vue-id.ts] N/A 58.5 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 21.7 µs N/A
🆕 lexer[antd.js] N/A 25 ms N/A
🆕 lexer[cal.com.tsx] N/A 6.1 ms N/A
🆕 lexer[checker.ts] N/A 14.9 ms N/A
🆕 lexer[pdf.mjs] N/A 4 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.8 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 3.1 s N/A
🆕 mangler[antd.js] N/A 16 ms N/A
🆕 mangler[react.development.js] N/A 294 µs N/A
🆕 mangler[typescript.js] N/A 39.6 ms N/A
🆕 minifier[antd.js] N/A 164.4 ms N/A
🆕 minifier[react.development.js] N/A 1.8 ms N/A
🆕 minifier[typescript.js] N/A 288.8 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label May 14, 2025
Copy link
Member

Boshen commented May 14, 2025

Merge activity

graphite-app bot pushed a commit that referenced this pull request May 14, 2025
It's unnecessary to have a separate `errors.rs` file for `SourceType`. Combine 2 files into 1.

Pure refactor. This PR doesn't alter any of the logic, just relocates it.
@graphite-app graphite-app bot force-pushed the 05-14-refactor_span_remove_source_type_module branch from 21ad30a to f068127 Compare May 14, 2025 08:50
It's unnecessary to have a separate `errors.rs` file for `SourceType`. Combine 2 files into 1.

Pure refactor. This PR doesn't alter any of the logic, just relocates it.
@graphite-app graphite-app bot force-pushed the 05-14-refactor_span_remove_source_type_module branch from f068127 to 567368e Compare May 14, 2025 09:11
@graphite-app graphite-app bot merged commit 567368e into main May 14, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 05-14-refactor_span_remove_source_type_module branch May 14, 2025 09:17
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants