Skip to content

refactor(lexer): tidy tests for Token#11011

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-13-refactor_lexer_tidy_tests_for_token_
May 13, 2025
Merged

refactor(lexer): tidy tests for Token#11011
graphite-app[bot] merged 1 commit intomainfrom
05-13-refactor_lexer_tidy_tests_for_token_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 13, 2025

Follow-on after #10933. That PR made some cosmetic changes to the tests for Token which weren't necessary. Revert them.

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels May 13, 2025
@overlookmotel overlookmotel marked this pull request as ready for review May 13, 2025 15:23
@overlookmotel
Copy link
Member Author

Cosmetic changes only, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label May 13, 2025
Copy link
Member Author

overlookmotel commented May 13, 2025

Merge activity

Follow-on after #10933. That PR made some cosmetic changes to the tests for `Token` which weren't necessary. Revert them.
@graphite-app graphite-app bot force-pushed the 05-13-refactor_lexer_tidy_tests_for_token_ branch from 35fa5cc to 54bfb4b Compare May 13, 2025 15:29
@codspeed-hq
Copy link

codspeed-hq bot commented May 13, 2025

CodSpeed Instrumentation Performance Report

Merging #11011 will not alter performance

Comparing 05-13-refactor_lexer_tidy_tests_for_token_ (54bfb4b) with main (cfd1ed3)

Summary

✅ 36 untouched benchmarks

@graphite-app graphite-app bot merged commit 54bfb4b into main May 13, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 05-13-refactor_lexer_tidy_tests_for_token_ branch May 13, 2025 15:36
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant