Skip to content

refactor(parser/lexer): shorten code#10999

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-13-refactor_parser_lexer_shorten_code
May 13, 2025
Merged

refactor(parser/lexer): shorten code#10999
graphite-app[bot] merged 1 commit intomainfrom
05-13-refactor_parser_lexer_shorten_code

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 13, 2025

Pure refactor. Shorten code by using Option::get_or_insert_with.

@github-actions github-actions bot added A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels May 13, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review May 13, 2025 11:01
@overlookmotel
Copy link
Member Author

Small and uncontroversial change, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label May 13, 2025
Copy link
Member Author

overlookmotel commented May 13, 2025

Merge activity

@codspeed-hq
Copy link

codspeed-hq bot commented May 13, 2025

CodSpeed Instrumentation Performance Report

Merging #10999 will not alter performance

Comparing 05-13-refactor_parser_lexer_shorten_code (c993edd) with main (13dbcc6)

Summary

✅ 33 untouched benchmarks
🆕 3 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.8 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 3.1 s N/A

Pure refactor. Shorten code by using `Option::get_or_insert_with`.
@graphite-app graphite-app bot force-pushed the 05-13-refactor_parser_lexer_shorten_code branch from f1301c2 to c993edd Compare May 13, 2025 11:10
@graphite-app graphite-app bot merged commit c993edd into main May 13, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 05-13-refactor_parser_lexer_shorten_code branch May 13, 2025 11:17
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-parser Area - Parser C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant