fix(isolated-declarations): lost leading comments of export default function/class/interface#10990
Merged
graphite-app[bot] merged 1 commit intomainfrom May 13, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-isolated-declarations
CodSpeed Instrumentation Performance ReportMerging #10990 will not alter performanceComparing Summary
|
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the issue where leading comments for export default functions, classes, or interfaces were lost.
- Updated test snapshots to include the expected leading comment.
- Adjusted the source code in the fixture and module to correctly retain and attach leading comments without affecting functionality.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| crates/oxc_isolated_declarations/tests/snapshots/export-default.snap | Snapshot updated with the expected leading comment for the class. |
| crates/oxc_isolated_declarations/tests/fixtures/export-default.ts | Moved the leading comment to precede the class definition and applied minor formatting improvements. |
| crates/oxc_isolated_declarations/src/module.rs | Refactored comment handling logic to preserve comments based on the presence of a variable declaration. |
Member
Merge activity
|
graphite-app
bot
force-pushed
the
05-13-fix_isolated-declarations_lost_leading_comments_of_export_default_function_class_interface
branch
from
61ec046 to
9a4b135
Compare
graphite-app
bot
deleted the
05-13-fix_isolated-declarations_lost_leading_comments_of_export_default_function_class_interface
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
close: #10989