Skip to content

refactor(ast_visit): descriptive method param names in Utf8ToUtf16Converter#10987

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-12-refactor_ast_visit_descriptive_method_param_names_in_utf8toutf16converter_
May 12, 2025
Merged

refactor(ast_visit): descriptive method param names in Utf8ToUtf16Converter#10987
graphite-app[bot] merged 1 commit intomainfrom
05-12-refactor_ast_visit_descriptive_method_param_names_in_utf8toutf16converter_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 12, 2025

Pure refactor. Rename function params to be more descriptive than it.

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels May 12, 2025
@overlookmotel overlookmotel marked this pull request as ready for review May 12, 2025 22:54
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label May 12, 2025
Copy link
Member Author

overlookmotel commented May 12, 2025

Merge activity

@codspeed-hq
Copy link

codspeed-hq bot commented May 12, 2025

CodSpeed Instrumentation Performance Report

Merging #10987 will not alter performance

Comparing 05-12-refactor_ast_visit_descriptive_method_param_names_in_utf8toutf16converter_ (287b3c3) with main (9eedb58)

Summary

✅ 36 untouched benchmarks

graphite-app bot pushed a commit that referenced this pull request May 12, 2025
…nverter` (#10987)

Pure refactor. Rename function params to be more descriptive than `it`.
@graphite-app graphite-app bot force-pushed the 05-12-refactor_ast_visit_descriptive_method_param_names_in_utf8toutf16converter_ branch from 5890fcc to 16dc9bf Compare May 12, 2025 23:01
…nverter` (#10987)

Pure refactor. Rename function params to be more descriptive than `it`.
@overlookmotel overlookmotel force-pushed the 05-12-refactor_ast_visit_descriptive_method_param_names_in_utf8toutf16converter_ branch from 16dc9bf to 287b3c3 Compare May 12, 2025 23:11
@graphite-app graphite-app bot merged commit 287b3c3 into main May 12, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 05-12-refactor_ast_visit_descriptive_method_param_names_in_utf8toutf16converter_ branch May 12, 2025 23:17
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant