Skip to content

fix(language_server): normalize oxlintrc config path#10982

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-12-fix_language_server_strip_.__from_configpath_
May 13, 2025
Merged

fix(language_server): normalize oxlintrc config path#10982
graphite-app[bot] merged 1 commit intomainfrom
05-12-fix_language_server_strip_.__from_configpath_

Conversation

@Sysix
Copy link
Member

@Sysix Sysix commented May 12, 2025

closes #10941

Copy link
Member Author

Sysix commented May 12, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-editor Area - Editor and Language Server C-bug Category - Bug labels May 12, 2025
@Sysix Sysix force-pushed the 05-12-fix_language_server_strip_.__from_configpath_ branch from 93c143e to e442024 Compare May 12, 2025 18:18
@codspeed-hq
Copy link

codspeed-hq bot commented May 12, 2025

CodSpeed Instrumentation Performance Report

Merging #10982 will not alter performance

Comparing 05-12-fix_language_server_strip_._from_configpath (89cc21b) with main (17e49c3)

Summary

✅ 36 untouched benchmarks

@Sysix Sysix changed the title fix(language_server): strip "./" from configPath fix(language_server): normalize configPath May 12, 2025
@Sysix Sysix changed the title fix(language_server): normalize configPath fix(language_server): normalize oxlintrc config path May 12, 2025
@Sysix Sysix marked this pull request as ready for review May 12, 2025 18:21
@Sysix Sysix requested a review from camc314 as a code owner May 12, 2025 18:21
@camc314 camc314 added the 0-merge Merge with Graphite Merge Queue label May 13, 2025
Copy link
Contributor

camc314 commented May 13, 2025

Merge activity

graphite-app bot pushed a commit that referenced this pull request May 13, 2025
@graphite-app graphite-app bot force-pushed the 05-12-fix_language_server_strip_.__from_configpath_ branch from e442024 to 5ef5b10 Compare May 13, 2025 08:30
@graphite-app graphite-app bot force-pushed the 05-12-fix_language_server_strip_.__from_configpath_ branch from 5ef5b10 to 89cc21b Compare May 13, 2025 08:31
@graphite-app graphite-app bot merged commit 89cc21b into main May 13, 2025
25 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 13, 2025
@graphite-app graphite-app bot deleted the 05-12-fix_language_server_strip_.__from_configpath_ branch May 13, 2025 08:34
camc314 added a commit that referenced this pull request May 16, 2025
## [0.16.11] - 2025-05-16

### Features

- 078bf0b language_server: Better fallback handling when passing invalid
`Options` values (#10930) (Sysix)
- be7f7e1 language_server/editor: Support multi workspace folders
(#10875) (Sysix)
- eef93b4 linter: Add import/no-unassigned-import (#10970) (yefan)
- cc0112f linter: No-unused-vars add setting for
`reportVarsOnlyUsedAsTypes` (#11009) (camc314)
- 17e49c3 linter: Implement configuration and checking loops for
`eslint/no_constant_condition` (#10949) (Ulrich Stark)
- 21117ac linter: Implement react/forbid-elements (#10928) (Thomas
BOCQUEZ)
- 466c24a linter: Add gitlab reporter output format (#10927) (Connor
Pearson)
- a064082 linter: Add import/consistent-type-specifier-style rule
(#10858) (yefan)
- 4733b52 linter/no-extraneous-class: Add conditional fixer (#10798)
(DonIsaac)

### Bug Fixes

- 87bf2a8 editor: Send only `workspace/didChangeConfiguration` when some
workspace configuration is effected (#11017) (Sysix)
- ed5708d editor: Detect all workspaces config path changes (#11016)
(Sysix)
- 89cc21b language_server: Normalize oxlintrc config path (#10982)
(Sysix)
- c52a9ba linter: Fix plugins inside overrides not being applied
(#11057) (camc314)
- b12bd48 linter: Fix rule config not being correctly applied (#11055)
(camc314)
- 9a368be linter: False negative in no-restriced-imports with `patterns`
and side effects (#11027) (camc314)
- 8c2cfbc linter: False negative in no-restricted-imports (#11026)
(camc314)
- 8956870 linter: False positive in no-unused-vars (#11002) (camc314)
- 33a60d2 linter: Skip eslint/no-redeclare when running on modules
(#11004) (camc314)
- 39063ce linter: Reword diagnostic message for no-control-regex
(#10993) (camc314)
- 9eedb58 linter: False positive with negative matches in
no-restricted-imports (#10976) (camc314)
- 10e77d7 linter: Improve diagnostics for no-control-regex (#10959)
(camc314)
- 0961296 linter: Add `gitlab` to linter `--help` docs (#10932)
(camc314)
- 82889ae linter/no-extraneous-class: Improve docs, reporting and code
refactor (#10797) (DonIsaac)
- 11c34e7 linter/no-img-element: Improve diagnostic and docs (#10908)
(DonIsaac)
- 584d8b9 napi: Enable mimalloc `no_opt_arch` feature on linux aarch64
(#11053) (Boshen)
- 126ae75 semantic: Distinguish class private elements (#11044)
(magic-akari)
- 773d0de semantic: Correctly handle nested brackets in jsdoc parsing
(#10922) (camc314)
- b215b6c semantic: Dont parse `@` as jsdoc tags inside `[`/`]` (#10919)
(camc314)

### Documentation

- db6afb9 linter: Improve docs of no-debugger (#11033) (camc314)
- 16541de linter: Improve docs of default-param-last (#11032) (camc314)
- 2c2f3c4 linter: Improve docs of default-case-last (#11031) (camc314)
- 56bb9ce linter: Improve docs of array-callback-return (#11030)
(camc314)
- 13dbcc6 linter: Correct docs for default config for no-redeclare
(#10995) (camc314)
- a86cbb3 linter: Fix incorrect backticks of fenced code blocks (#10947)
(Ulrich Stark)

### Refactor

- 3cc1466 language_server: New configuration structure for `initialize`
and `workspace/didChangeConfiguration` (#10890) (Sysix)
- bd2ef7d language_server: Use `Arc` for `diagnostic_report_map`
(#10940) (Sysix)
- bb999a3 language_server: Avoid cloning linter by taking reference in
LintService (#10907) (Ulrich Stark)
- d1b0c83 linter: Remove overrides index vec (#11058) (camc314)
- 7ad6cf8 linter: Store severity separately, remove `RuleWithSeverity`
(#11051) (camchenry)
- e31c361 linter: Remove nested match statements in
no-restricted-imports (#10975) (camc314)
- 6ad9d4f linter: Tidy `eslint/func-names` (#10923) (camc314)
- faf0a95 syntax: Rename `NameSpaceModule` to `NamespaceModule` (#10917)
(Dunqing)

### Testing

- 76b6b33 editor: Add tests for multi workspace folder setup (#10904)
(Sysix)

Co-authored-by: camc314 <18101008+camc314@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-editor Area - Editor and Language Server C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

language_server: crashed with custom config path + ignorePatterns

2 participants