Skip to content

perf(ast/estree): streamline raw deserializer for WithClause#10974

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-12-perf_ast_estree_streamline_raw_deserializer_for_withclause_
May 12, 2025
Merged

perf(ast/estree): streamline raw deserializer for WithClause#10974
graphite-app[bot] merged 1 commit intomainfrom
05-12-perf_ast_estree_streamline_raw_deserializer_for_withclause_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 12, 2025

All the fields of WithClause except with_entries are ignored, so there's no point deserializing them.

@github-actions github-actions bot added A-ast Area - AST C-performance Category - Solution not expected to change functional behavior, only performance labels May 12, 2025
Copy link
Member Author

overlookmotel commented May 12, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review May 12, 2025 14:43
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label May 12, 2025
Copy link
Member Author

overlookmotel commented May 12, 2025

Merge activity

  • May 12, 10:43 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • May 12, 10:50 AM EDT: overlookmotel added this pull request to the Graphite merge queue.
  • May 12, 11:24 AM EDT: The Graphite merge queue removed this pull request due to downstack failures on PR #10972.
  • May 12, 1:30 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • May 12, 1:37 PM EDT: overlookmotel added this pull request to the Graphite merge queue.
  • May 12, 1:45 PM EDT: Merged by the Graphite merge queue.

@codspeed-hq
Copy link

codspeed-hq bot commented May 12, 2025

CodSpeed Instrumentation Performance Report

Merging #10974 will create unknown performance changes

Comparing 05-12-perf_ast_estree_streamline_raw_deserializer_for_withclause_ (a4b5716) with main (6cc74ff)

Summary

🆕 36 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 codegen[checker.ts] N/A 22.1 ms N/A
🆕 codegen_sourcemap[checker.ts] N/A 65.1 ms N/A
🆕 formatter[antd.js] N/A 714.5 ms N/A
🆕 formatter[react.development.js] N/A 8.1 ms N/A
🆕 formatter[typescript.js] N/A 1.1 s N/A
🆕 isolated-declarations[vue-id.ts] N/A 58.5 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 21.2 µs N/A
🆕 lexer[antd.js] N/A 24.1 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.8 ms N/A
🆕 lexer[checker.ts] N/A 14.4 ms N/A
🆕 lexer[pdf.mjs] N/A 3.9 ms N/A
🆕 linter[RadixUIAdoptionSection.jsx] N/A 2.8 ms N/A
🆕 linter[cal.com.tsx] N/A 1.2 s N/A
🆕 linter[checker.ts] N/A 3.1 s N/A
🆕 mangler[antd.js] N/A 16 ms N/A
🆕 mangler[react.development.js] N/A 293.7 µs N/A
🆕 mangler[typescript.js] N/A 39.6 ms N/A
🆕 minifier[antd.js] N/A 164.4 ms N/A
🆕 minifier[react.development.js] N/A 1.8 ms N/A
🆕 minifier[typescript.js] N/A 288.9 ms N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 12, 2025
@overlookmotel overlookmotel force-pushed the 05-12-perf_ast_estree_streamline_raw_deserializer_for_withclause_ branch from 5daca79 to 9433190 Compare May 12, 2025 17:30
@overlookmotel overlookmotel force-pushed the 05-12-refactor_ast_estree_add_semi-colon branch from a1aaed7 to 7b97ce4 Compare May 12, 2025 17:30
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label May 12, 2025
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 12, 2025
All the fields of `WithClause` except `with_entries` are ignored, so there's no point deserializing them.
@graphite-app graphite-app bot force-pushed the 05-12-refactor_ast_estree_add_semi-colon branch from 7b97ce4 to 6cc74ff Compare May 12, 2025 17:38
@graphite-app graphite-app bot force-pushed the 05-12-perf_ast_estree_streamline_raw_deserializer_for_withclause_ branch from 9433190 to a4b5716 Compare May 12, 2025 17:38
Base automatically changed from 05-12-refactor_ast_estree_add_semi-colon to main May 12, 2025 17:44
@graphite-app graphite-app bot merged commit a4b5716 into main May 12, 2025
27 checks passed
@graphite-app graphite-app bot deleted the 05-12-perf_ast_estree_streamline_raw_deserializer_for_withclause_ branch May 12, 2025 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-performance Category - Solution not expected to change functional behavior, only performance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant