Skip to content

refactor(ast/estree): rename serializers#10969

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-12-refactor_ast_estree_rename_serializers
May 12, 2025
Merged

refactor(ast/estree): rename serializers#10969
graphite-app[bot] merged 1 commit intomainfrom
05-12-refactor_ast_estree_rename_serializers

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 12, 2025

Pure refactor. Rename AssignmentTargetPropertyIdentifierInit and JSXElementOpeningElement serializers, to follow the naming convention of <type name><field name>.

@overlookmotel overlookmotel marked this pull request as ready for review May 12, 2025 14:18
@github-actions github-actions bot added the A-ast Area - AST label May 12, 2025
Copy link
Member Author

overlookmotel commented May 12, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior label May 12, 2025
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label May 12, 2025
Copy link
Member Author

overlookmotel commented May 12, 2025

Merge activity

@graphite-app graphite-app bot changed the base branch from 05-12-docs_ast_estree_standardize_doc_comments_for_estree_serializers to graphite-base/10969 May 12, 2025 14:24
@codspeed-hq
Copy link

codspeed-hq bot commented May 12, 2025

CodSpeed Instrumentation Performance Report

Merging #10969 will not alter performance

Comparing 05-12-refactor_ast_estree_rename_serializers (2958ff7) with main (b23fef7)

Summary

✅ 36 untouched benchmarks

@graphite-app graphite-app bot changed the base branch from graphite-base/10969 to main May 12, 2025 14:30
Pure refactor. Rename `AssignmentTargetPropertyIdentifierInit` and `JSXElementOpeningElement` serializers, to follow the naming convention of `<type name><field name>`.
@graphite-app graphite-app bot force-pushed the 05-12-refactor_ast_estree_rename_serializers branch from 6760350 to 2958ff7 Compare May 12, 2025 14:31
@graphite-app graphite-app bot merged commit 2958ff7 into main May 12, 2025
26 checks passed
@graphite-app graphite-app bot deleted the 05-12-refactor_ast_estree_rename_serializers branch May 12, 2025 14:37
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant