Skip to content

docs(ast/estree): standardize doc comments for ESTree serializers #10968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
May 12, 2025
+3 −3
Merged

docs(ast/estree): standardize doc comments for ESTree serializers #10968

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/oxc_ast/src/serialize/js.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@ impl ESTree for MethodDefinitionKey<'_, '_> {
}
}

/// Serializer for `ArrowFunctionExpression`'s `body` field.
/// Serializer for `body` field of `ArrowFunctionExpression`.
///
/// Serialize as either an expression (if `expression` property is set),
/// or a `BlockStatement` (if it's not).
Expand All @@ -350,7 +350,7 @@ impl ESTree for ArrowFunctionExpressionBody<'_> {
}
}

/// Serializer for `AssignmentTargetPropertyIdentifier`'s `init` field
/// Serializer for `init` field of `AssignmentTargetPropertyIdentifier`
/// (which is renamed to `value` in ESTree AST).
#[ast_meta]
#[estree(
Expand Down
2 changes: 1 addition & 1 deletion crates/oxc_ast/src/serialize/ts.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ impl ESTree for TSEnumMemberComputed<'_, '_> {

/// Serializer for `directive` field of `ExpressionStatement`.
///
/// This field is always `null`, and only appears in the TS AST, not JS ESTree.
/// This field is always `null`, and only appears in the TS-ESTree AST, not JS ESTree.
#[ast_meta]
#[estree(ts_type = "string | null", raw_deser = "null")]
#[ts]
Expand Down
Loading