Skip to content

refactor(ast/estree): split custom serializers into multiple files#10967

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-11-refactor_ast_estree_split_custom_serializers_into_multiple_files
May 12, 2025
Merged

refactor(ast/estree): split custom serializers into multiple files#10967
graphite-app[bot] merged 1 commit intomainfrom
05-11-refactor_ast_estree_split_custom_serializers_into_multiple_files

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 12, 2025

Pure refactor. serialize.rs had got too large. Split it up into multiple files.

Also make sure all custom serializers/converters have clear doc comments.

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels May 12, 2025
@overlookmotel overlookmotel marked this pull request as ready for review May 12, 2025 13:15
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label May 12, 2025
Copy link
Member Author

overlookmotel commented May 12, 2025

Merge activity

@codspeed-hq
Copy link

codspeed-hq bot commented May 12, 2025

CodSpeed Instrumentation Performance Report

Merging #10967 will not alter performance

Comparing 05-11-refactor_ast_estree_split_custom_serializers_into_multiple_files (b8018b9) with main (a39eb85)

Summary

✅ 36 untouched benchmarks

…10967)

Pure refactor. `serialize.rs` had got too large. Split it up into multiple files.

Also make sure all custom serializers/converters have clear doc comments.
@graphite-app graphite-app bot force-pushed the 05-11-refactor_ast_estree_split_custom_serializers_into_multiple_files branch from b6e0c6d to b8018b9 Compare May 12, 2025 13:58
@graphite-app graphite-app bot merged commit b8018b9 into main May 12, 2025
25 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 12, 2025
@graphite-app graphite-app bot deleted the 05-11-refactor_ast_estree_split_custom_serializers_into_multiple_files branch May 12, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-ast-tools Area - AST tools C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant