Skip to content

fix(ast/estree): fix field order for FormalParameter#10962

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-09-fix_ast_estree_fix_field_order_for_formalparameter_
May 12, 2025
Merged

fix(ast/estree): fix field order for FormalParameter#10962
graphite-app[bot] merged 1 commit intomainfrom
05-09-fix_ast_estree_fix_field_order_for_formalparameter_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 12, 2025

Order last 3 fields: decorators, optional, typeAnnotation - to match these types in other positions.

@github-actions github-actions bot added A-ast Area - AST C-bug Category - Bug labels May 12, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review May 12, 2025 11:19
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label May 12, 2025
Copy link
Member Author

overlookmotel commented May 12, 2025

Merge activity

@codspeed-hq
Copy link

codspeed-hq bot commented May 12, 2025

CodSpeed Instrumentation Performance Report

Merging #10962 will not alter performance

Comparing 05-09-fix_ast_estree_fix_field_order_for_formalparameter_ (53329f8) with main (8b8f78f)

Summary

✅ 36 untouched benchmarks

Order last 3 fields: `decorators`, `optional`, `typeAnnotation` - to match these types in other positions.
@graphite-app graphite-app bot force-pushed the 05-09-fix_ast_estree_fix_field_order_for_formalparameter_ branch from 577f4b0 to 53329f8 Compare May 12, 2025 11:35
@graphite-app graphite-app bot merged commit 53329f8 into main May 12, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 05-09-fix_ast_estree_fix_field_order_for_formalparameter_ branch May 12, 2025 11:41
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant