feat(napi): add arm musl#10958
feat(napi): add arm musl#10958Boshen merged 2 commits intooxc-project:mainfrom kaaax0815:feat-arm-musl
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
|
I'll trigger a build in another branch to test the build. |
There was a problem hiding this comment.
Pull Request Overview
This PR introduces support for compiling arm musl builds by adding a new target triple for armv7 in various npm package configurations and updating the release workflow.
- Added a new target "armv7-unknown-linux-musleabihf" to package.json files in napi/transform, napi/parser, and napi/minify.
- Updated the GitHub reusable release workflow to build against the new target.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| napi/transform/package.json | Added new arm musl target entry |
| napi/parser/package.json | Added new arm musl target entry |
| napi/minify/package.json | Added new arm musl target entry |
| .github/workflows/reusable_release_napi.yml | Added new job configuration for arm musl target build |
Comments suppressed due to low confidence (4)
napi/transform/package.json:55
- Please verify that the new target triple 'armv7-unknown-linux-musleabihf' adheres to the expected naming convention; consider if a hyphen should separate 'musl' and 'eabihf' to align with standard formats.
"armv7-unknown-linux-musleabihf",
napi/parser/package.json:76
- Please verify that the new target triple 'armv7-unknown-linux-musleabihf' uses the correct naming convention; consider if adding a hyphen between 'musl' and 'eabihf' is necessary.
"armv7-unknown-linux-musleabihf",
napi/minify/package.json:55
- Please ensure that the new target triple 'armv7-unknown-linux-musleabihf' is correctly formatted according to expected conventions; check if a hyphen is needed between 'musl' and 'eabihf'.
"armv7-unknown-linux-musleabihf",
.github/workflows/reusable_release_napi.yml:90
- Please confirm that the target name 'armv7-unknown-linux-musleabihf' used in the workflow matches the intended naming convention for musl-based builds; a hyphen between 'musl' and 'eabihf' might be needed based on standard target triple formats.
target: armv7-unknown-linux-musleabihf
|
It seems that the build is failing. https://github.com/oxc-project/oxc/actions/runs/14969756667/job/42047839596 |
closes #10954