Skip to content

feat(napi): add arm musl#10958

Merged
Boshen merged 2 commits intooxc-project:mainfrom
kaaax0815:feat-arm-musl
May 12, 2025
Merged

feat(napi): add arm musl#10958
Boshen merged 2 commits intooxc-project:mainfrom
kaaax0815:feat-arm-musl

Conversation

@kaaax0815
Copy link
Contributor

@kaaax0815 kaaax0815 commented May 12, 2025

closes #10954

@graphite-app
Copy link
Contributor

graphite-app bot commented May 12, 2025

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

@kaaax0815 kaaax0815 changed the title feat: add arm musl feat(napi): add arm musl May 12, 2025
@github-actions github-actions bot added the C-enhancement Category - New feature or request label May 12, 2025
@Boshen
Copy link
Member

Boshen commented May 12, 2025

I'll trigger a build in another branch to test the build.

@kaaax0815 kaaax0815 marked this pull request as ready for review May 12, 2025 10:21
Copilot AI review requested due to automatic review settings May 12, 2025 10:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces support for compiling arm musl builds by adding a new target triple for armv7 in various npm package configurations and updating the release workflow.

  • Added a new target "armv7-unknown-linux-musleabihf" to package.json files in napi/transform, napi/parser, and napi/minify.
  • Updated the GitHub reusable release workflow to build against the new target.

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
napi/transform/package.json Added new arm musl target entry
napi/parser/package.json Added new arm musl target entry
napi/minify/package.json Added new arm musl target entry
.github/workflows/reusable_release_napi.yml Added new job configuration for arm musl target build
Comments suppressed due to low confidence (4)

napi/transform/package.json:55

  • Please verify that the new target triple 'armv7-unknown-linux-musleabihf' adheres to the expected naming convention; consider if a hyphen should separate 'musl' and 'eabihf' to align with standard formats.
"armv7-unknown-linux-musleabihf",

napi/parser/package.json:76

  • Please verify that the new target triple 'armv7-unknown-linux-musleabihf' uses the correct naming convention; consider if adding a hyphen between 'musl' and 'eabihf' is necessary.
"armv7-unknown-linux-musleabihf",

napi/minify/package.json:55

  • Please ensure that the new target triple 'armv7-unknown-linux-musleabihf' is correctly formatted according to expected conventions; check if a hyphen is needed between 'musl' and 'eabihf'.
"armv7-unknown-linux-musleabihf",

.github/workflows/reusable_release_napi.yml:90

  • Please confirm that the target name 'armv7-unknown-linux-musleabihf' used in the workflow matches the intended naming convention for musl-based builds; a hyphen between 'musl' and 'eabihf' might be needed based on standard target triple formats.
target: armv7-unknown-linux-musleabihf

@kaaax0815
Copy link
Contributor Author

kaaax0815 commented May 12, 2025

It seems that the build is failing. https://github.com/oxc-project/oxc/actions/runs/14969756667/job/42047839596
but i don't know why

@Boshen Boshen merged commit 647b6f3 into oxc-project:main May 12, 2025
1 check passed
@kaaax0815 kaaax0815 deleted the feat-arm-musl branch May 12, 2025 12:46
@kaaax0815 kaaax0815 mentioned this pull request May 12, 2025
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add armv7 musl support to oxc-parser

3 participants