refactor(parser): make Token fields private

[Boshen]

The goal of this PR is to reduce the diff for #10933

[Boshen]

• refactor(parser): make Token fields private #10936 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[Copilot]

Pull Request Overview

This PR refactors the parser module by making all Token fields private and replacing direct field accesses with accessor methods. Key changes include modifying Token field accesses in lexer, template, string, regex, and other modules; updating related tests; and enforcing internal encapsulation for Token.

Reviewed Changes

Copilot reviewed 27 out of 27 changed files in this pull request and generated 1 comment.

File	Description
crates/oxc_parser/src/lexer/trivia_builder.rs	Accessor replacements for token.kind and token.start
crates/oxc_parser/src/lexer/token.rs	Token fields made private and new getters/setters added
Other lexer files (template, string, regex, etc.)	Updates to use the new accessor methods consistently
crates/oxc_parser/src/js/* and crates/oxc_parser/src/cursor.rs	Adjustments to token field accesses using the new methods

Comments suppressed due to low confidence (1)

crates/oxc_parser/src/lexer/token.rs:93

• Consider verifying that reducing the visibility of the 'has_separator' accessor to crate level does not negatively impact any external modules or tests that previously relied on public access to this field.

pub(crate) fn has_separator(&self) -> bool {

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #10936 will not alter performance

_{Comparing token-api (b526da9) with main (4733b52)}

Summary

✅ 36 untouched benchmarks

[graphite-app]

Merge activity

• May 10, 11:56 PM EDT: Boshen added this pull request to the Graphite merge queue.
• May 11, 12:04 AM EDT: Merged by the Graphite merge queue.