Skip to content

fix(ast)!: fix field order for TSTypeAssertion#10906

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-08-fix_ast_fix_field_order_for_tstypeassertion_
May 9, 2025
Merged

fix(ast)!: fix field order for TSTypeAssertion#10906
graphite-app[bot] merged 1 commit intomainfrom
05-08-fix_ast_fix_field_order_for_tstypeassertion_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 8, 2025

Fix field order for TSTypeAssertion. Move type_annotation to before expression, because it comes first in source:

//                ___ expression
let foo = <number>bar;
//        ^^^^^^^^ type_annotation

@github-actions github-actions bot added A-parser Area - Parser A-semantic Area - Semantic A-ast Area - AST C-bug Category - Bug labels May 8, 2025
Copy link
Member Author

overlookmotel commented May 8, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review May 8, 2025 19:05
@overlookmotel overlookmotel requested a review from Dunqing as a code owner May 8, 2025 19:05
@codspeed-hq
Copy link

codspeed-hq bot commented May 8, 2025

CodSpeed Instrumentation Performance Report

Merging #10906 will not alter performance

Comparing 05-08-fix_ast_fix_field_order_for_tstypeassertion_ (2b5d826) with main (4863eef)

Summary

✅ 36 untouched benchmarks

@Boshen Boshen added the 0-merge Merge with Graphite Merge Queue label May 9, 2025
Copy link
Member

Boshen commented May 9, 2025

Merge activity

Fix field order for `TSTypeAssertion`. Move `type_annotation` to before `expression`, because it comes first in source:

```ts
//                ___ expression
let foo = <number>bar;
//        ^^^^^^^^ type_annotation
```
@graphite-app graphite-app bot force-pushed the 05-08-fix_ast_fix_field_order_for_tsnamedtuplemember_ branch from 59e13f2 to 1f35910 Compare May 9, 2025 01:35
@graphite-app graphite-app bot force-pushed the 05-08-fix_ast_fix_field_order_for_tstypeassertion_ branch from c06a934 to 2b5d826 Compare May 9, 2025 01:36
Base automatically changed from 05-08-fix_ast_fix_field_order_for_tsnamedtuplemember_ to main May 9, 2025 01:41
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 9, 2025
@graphite-app graphite-app bot merged commit 2b5d826 into main May 9, 2025
28 checks passed
@graphite-app graphite-app bot deleted the 05-08-fix_ast_fix_field_order_for_tstypeassertion_ branch May 9, 2025 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-parser Area - Parser A-semantic Area - Semantic C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants