Skip to content

fix(ast)!: fix field order for NewExpression#10893

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-08-fix_ast_fix_field_order_for_newexpression_
May 8, 2025
Merged

fix(ast)!: fix field order for NewExpression#10893
graphite-app[bot] merged 1 commit intomainfrom
05-08-fix_ast_fix_field_order_for_newexpression_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 8, 2025

Fix field order for NewExpression. Move type_arguments to before arguments, because they come first in source:

const foo = new Foo<T>(1, 2, 3);

@github-actions github-actions bot added the A-parser Area - Parser label May 8, 2025
Copy link
Member Author

overlookmotel commented May 8, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-ast Area - AST A-transformer Area - Transformer / Transpiler C-bug Category - Bug labels May 8, 2025
@overlookmotel overlookmotel marked this pull request as ready for review May 8, 2025 12:26
@overlookmotel overlookmotel requested a review from Dunqing as a code owner May 8, 2025 12:26
@codspeed-hq
Copy link

codspeed-hq bot commented May 8, 2025

CodSpeed Instrumentation Performance Report

Merging #10893 will not alter performance

Comparing 05-08-fix_ast_fix_field_order_for_newexpression_ (5746d36) with main (553ab5b)

Summary

✅ 36 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 05-08-fix_ast_fix_field_order_for_newexpression_ branch from b958ba1 to 5d007ad Compare May 8, 2025 15:26
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label May 8, 2025
Copy link
Member Author

overlookmotel commented May 8, 2025

Merge activity

Fix field order for `NewExpression`. Move `type_arguments` to before `arguments`, because they come first in source:

```tsx
const foo = new Foo<T>(1, 2, 3);
```
@graphite-app graphite-app bot force-pushed the 05-08-fix_ast_fix_field_order_for_newexpression_ branch from 5d007ad to 5746d36 Compare May 8, 2025 15:34
@graphite-app graphite-app bot merged commit 5746d36 into main May 8, 2025
26 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 8, 2025
@graphite-app graphite-app bot deleted the 05-08-fix_ast_fix_field_order_for_newexpression_ branch May 8, 2025 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-parser Area - Parser A-transformer Area - Transformer / Transpiler C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants