Conversation
Contributor
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR implements support for the s390x-unknown-linux-gnu build for N-API by updating package.json files and the CI workflow configuration.
- Added the "s390x-unknown-linux-gnu" target to the transform, parser, and minify package.json files.
- Updated the CI workflow configuration to enable the s390x build using the appropriate build command and flags.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| napi/transform/package.json | Added "s390x-unknown-linux-gnu" to the list of supported build targets. |
| napi/parser/package.json | Added "s390x-unknown-linux-gnu" to the list of supported build targets. |
| napi/minify/package.json | Added "s390x-unknown-linux-gnu" to the list of supported build targets. |
| .github/workflows/reusable_release_napi.yml | Updated the workflow to uncomment and configure the s390x build target. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.