docs(ast): fix docs for ExportSpecifier

[overlookmotel]

The code examples were incorrect previously.

[overlookmotel]

• docs(ast): fix docs for ExportSpecifier #10891 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #10891 will not alter performance

_{Comparing 05-08-docs_ast_fix_docs_for_exportspecifier_ (206e07d) with main (6f3f9d7)}

Summary

✅ 36 untouched benchmarks

[overlookmotel]

@Dunqing Can I ask for your help with this one?

In this example, export_kind on the ExportNamedDeclaration is ImportOrExportKind::Type, but export_kind on the ExportSpecifier is ImportOrExportKind::Value:

export type { Foo as Bar };

That aligns with TS-ESLint. But it seems weird, because I assume the type keyword applies to all the ExportSpecifiers?

AST explorer

Either way, if you could please confirm what's intended behavior, I'll update this PR to document it (for the benefit of TS newbies like me!).

[camc314]

@overlookmotel i think these two are relevant to your question:
#10473
#10465 (comment)

[Dunqing]

@Dunqing Can I ask for your help with this one?

In this example, export_kind on the ExportNamedDeclaration is ImportOrExportKind::Type, but export_kind on the ExportSpecifier is ImportOrExportKind::Value:

export type { Foo as Bar };

That aligns with TS-ESLint. But it seems weird, because I assume the type keyword applies to all the ExportSpecifiers?

AST explorer

Either way, if you could please confirm what's intended behavior, I'll update this PR to document it (for the benefit of TS newbies like me!).

I just realized we couldn't set ImportOrExportKind::Type for ExportSpecifier, because it will break codegen. We should print the code as-is, see TypeScript and switch to .D.TS output. So the current behavior is correct, in terms of semantics, indeed, the child ExportSpecifier is type, though.

[overlookmotel]

Thanks both for patiently explaining to this TS noob.

I've updated the comment to (I think) explain what the export_kind field represents here. Could one of you please give it a quick check and make sure I have it right?

Edit: Cam is too fast! He's already reviewed in the time it took me to write this comment. Thank you.

[overlookmotel]

Merge activity

• May 12, 10:55 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• May 12, 11:13 AM EDT: overlookmotel added this pull request to the Graphite merge queue.
• May 12, 11:31 AM EDT: Merged by the Graphite merge queue.