Skip to content

fix(ast)!: re-order fields of TaggedTemplateExpression#10889

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-08-fix_ast_re-order_fields_of_taggedtemplateexpression_
May 8, 2025
Merged

fix(ast)!: re-order fields of TaggedTemplateExpression#10889
graphite-app[bot] merged 1 commit intomainfrom
05-08-fix_ast_re-order_fields_of_taggedtemplateexpression_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 8, 2025

Fix field order for TaggedTemplateExpression. Move type_arguments to before quasi, because they come first in source:

const foo = tag<T>`quasi`;

@github-actions github-actions bot added A-parser Area - Parser A-semantic Area - Semantic A-ast Area - AST labels May 8, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added the C-bug Category - Bug label May 8, 2025
@overlookmotel overlookmotel marked this pull request as ready for review May 8, 2025 11:50
@overlookmotel overlookmotel requested a review from Dunqing as a code owner May 8, 2025 11:50
@codspeed-hq
Copy link

codspeed-hq bot commented May 8, 2025

CodSpeed Instrumentation Performance Report

Merging #10889 will not alter performance

Comparing 05-08-fix_ast_re-order_fields_of_taggedtemplateexpression_ (0139793) with main (446d9b3)

Summary

✅ 36 untouched benchmarks

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label May 8, 2025
Copy link
Member Author

overlookmotel commented May 8, 2025

Merge activity

Fix field order for `TaggedTemplateExpression`. Move `type_arguments` to before `quasi`, because they come first in source:

```ts
const foo = tag<T>`quasi`;
```
@graphite-app graphite-app bot force-pushed the 05-08-fix_ast_re-order_fields_of_taggedtemplateexpression_ branch from f215329 to 0139793 Compare May 8, 2025 11:59
@graphite-app graphite-app bot merged commit 0139793 into main May 8, 2025
26 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 8, 2025
@graphite-app graphite-app bot deleted the 05-08-fix_ast_re-order_fields_of_taggedtemplateexpression_ branch May 8, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-parser Area - Parser A-semantic Area - Semantic C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants