fix(allocator): Allocator::from_raw_parts do not use const assertion for endianness test#10888
Merged
graphite-app[bot] merged 1 commit intomainfrom May 8, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #10888 will not alter performanceComparing Summary
|
camc314
approved these changes
May 8, 2025
Dunqing
approved these changes
May 8, 2025
Member
Merge activity
|
…n for endianness test (#10888) Currently we panic at compile time if attempt to compile `oxc_allocator` with `from_raw_parts` feature enabled on a big-endian system. Instead, panic at runtime. This will allow `napi/parser` to be built on big endian systems. The panic will still be optimized out on little-endian systems, and `napi/parser` will not use raw transfer on big endian, so `Allocator::from_raw_parts` won't be called, so this panic should never occur. But the check ensures the soundness of `Allocator::from_raw_parts`.
graphite-app
bot
force-pushed
the
05-08-fix_allocator_allocator_from_raw_parts_do_not_use_const_assertion_for_endianness_test
branch
from
c5c8f23 to
446d9b3
Compare
graphite-app
bot
deleted the
05-08-fix_allocator_allocator_from_raw_parts_do_not_use_const_assertion_for_endianness_test
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we panic at compile time if attempt to compile
oxc_allocatorwithfrom_raw_partsfeature enabled on a big-endian system. Instead, panic at runtime.This will allow
napi/parserto be built on big endian systems.The panic will still be optimized out on little-endian systems, and
napi/parserwill not use raw transfer on big endian, soAllocator::from_raw_partswon't be called, so this panic should never occur. But the check ensures the soundness ofAllocator::from_raw_parts.