Skip to content

fix(ast)!: fix field order for JSXElement and JSXFragment#10881

Merged
graphite-app[bot] merged 1 commit intomainfrom
05-08-fix_ast_fix_field_order_for_jsxelement_and_jsxfragment_
May 8, 2025
Merged

fix(ast)!: fix field order for JSXElement and JSXFragment#10881
graphite-app[bot] merged 1 commit intomainfrom
05-08-fix_ast_fix_field_order_for_jsxelement_and_jsxfragment_

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented May 8, 2025

Fix field order for JSXElement and JSXFragment. Move children field to before closing field, because children comes first in source.

Copy link
Member Author

overlookmotel commented May 8, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-parser Area - Parser A-ast Area - AST C-bug Category - Bug labels May 8, 2025
@overlookmotel overlookmotel marked this pull request as ready for review May 8, 2025 07:18
@overlookmotel overlookmotel changed the title fix(ast): fix field order for JSXElement and JSXFragment fix(ast)!: fix field order for JSXElement and JSXFragment May 8, 2025
@overlookmotel overlookmotel marked this pull request as draft May 8, 2025 07:24
@codspeed-hq
Copy link

codspeed-hq bot commented May 8, 2025

CodSpeed Instrumentation Performance Report

Merging #10881 will not alter performance

Comparing 05-08-fix_ast_fix_field_order_for_jsxelement_and_jsxfragment_ (cc2ed21) with main (d5cd29d)

Summary

✅ 36 untouched benchmarks

@overlookmotel overlookmotel force-pushed the 05-08-fix_ast_fix_field_order_for_jsxelement_and_jsxfragment_ branch from 53dacb9 to d470eb4 Compare May 8, 2025 07:26
@overlookmotel overlookmotel marked this pull request as ready for review May 8, 2025 07:26
@overlookmotel overlookmotel requested a review from Dunqing as a code owner May 8, 2025 07:26
@github-actions github-actions bot added the A-semantic Area - Semantic label May 8, 2025
@graphite-app graphite-app bot added the 0-merge Merge with Graphite Merge Queue label May 8, 2025
@graphite-app
Copy link
Contributor

graphite-app bot commented May 8, 2025

Merge activity

Fix field order for `JSXElement` and `JSXFragment`. Move `children` field to before closing field, because `children` comes first in source.
@graphite-app graphite-app bot force-pushed the 05-08-fix_ast_fix_field_order_for_jsxelement_and_jsxfragment_ branch from d470eb4 to cc2ed21 Compare May 8, 2025 07:58
@graphite-app graphite-app bot merged commit cc2ed21 into main May 8, 2025
27 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 8, 2025
@graphite-app graphite-app bot deleted the 05-08-fix_ast_fix_field_order_for_jsxelement_and_jsxfragment_ branch May 8, 2025 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST A-parser Area - Parser A-semantic Area - Semantic C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant