refactor(estree): remove regular expression types from ESTree AST#10855
Merged
graphite-app[bot] merged 1 commit intomainfrom May 7, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
A-ast
CodSpeed Instrumentation Performance ReportMerging #10855 will not alter performanceComparing Summary
|
graphite-app
bot
changed the base branch from
05-05-refactor_ast_simplify_regexppattern_
to
graphite-base/10855
graphite-app
bot
force-pushed
the
graphite-base/10855
branch
from
11f56a6 to
ad4fbf4
Compare
graphite-app
bot
force-pushed
the
05-05-refactor_estree_remove_regular_expression_types_from_estree_ast
branch
from
97be93d to
983a06c
Compare
graphite-app
bot
force-pushed
the
05-05-refactor_estree_remove_regular_expression_types_from_estree_ast
branch
from
983a06c to
5465876
Compare
Member
Merge activity
|
graphite-app bot
pushed a commit
that referenced
this pull request
May 7, 2025
…0855) `Pattern` and other types in `oxc_regular_expression` are not part of ESTree AST. Don't implement `ESTree`, and don't generate raw transfer deserializers for these types. None of that code is actually used. #10834 moved `Pattern` to an optional field of `RegExpPattern`, which is skipped in ESTree serialization, which enables now removing it from ESTree AST entirely. This reduces the scope of ESTree serialization.
graphite-app
bot
force-pushed
the
05-05-refactor_estree_remove_regular_expression_types_from_estree_ast
branch
from
5465876 to
776d7e1
Compare
Member
|
oops the other branch got merged first. |
…0855) `Pattern` and other types in `oxc_regular_expression` are not part of ESTree AST. Don't implement `ESTree`, and don't generate raw transfer deserializers for these types. None of that code is actually used. This reduces the scope of ESTree serialization.
overlookmotel
force-pushed
the
05-05-refactor_estree_remove_regular_expression_types_from_estree_ast
branch
from
776d7e1 to
daba0a7
Compare
graphite-app
bot
deleted the
05-05-refactor_estree_remove_regular_expression_types_from_estree_ast
branch
Contributor
|
Thanks for cleaning generated types 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patternand other types inoxc_regular_expressionare not part of ESTree AST. Don't implementESTree, and don't generate raw transfer deserializers for these types. None of that code is actually used.#10834 moved
Patternto an optional field ofRegExpPattern, which is skipped in ESTree serialization, which enables now removing it from ESTree AST entirely.This reduces the scope of ESTree serialization.