perf(data_structures): optimize InlineString#10850
Merged
graphite-app[bot] merged 1 commit intomainfrom May 7, 2025
Merged
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
github-actions
bot
added
the
C-performance
CodSpeed Instrumentation Performance ReportMerging #10850 will not alter performanceComparing Summary
|
This was referenced May 7, 2025
Member
Author
|
Small change, and I think I'm the member of the team who understands |
Member
Author
Merge activity
|
Small optimizations to `InlineString`. 1. Make it `Copy`. 2. Use an unchecked assertion about length of the string in `InlineString::as_str`. This provides the compiler with information which may allow it to make optimizations in the caller.
graphite-app
bot
force-pushed
the
05-06-perf_data_structures_optimize_inlinestring_
branch
from
6c514da to
2d4b8c9
Compare
graphite-app
bot
deleted the
05-06-perf_data_structures_optimize_inlinestring_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small optimizations to
InlineString.Copy.InlineString::as_str. This provides the compiler with information which may allow it to make optimizations in the caller.