ci(benchmarks): estree benchmark use black_box on result of to_estree_ts_json#10819
Merged
graphite-app[bot] merged 1 commit intomainfrom May 6, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
CodSpeed Instrumentation Performance ReportMerging #10819 will not alter performanceComparing Summary
|
Contributor
Merge activity
|
…ree_ts_json` (#10819) In benchmark for ESTree conversion, pass result of `program.to_estree_ts_json()` to `black_box`. Without it, if compiler was sufficiently clever, it could remove the entire call to `to_estree_ts_json` because the result is never used.
graphite-app
bot
force-pushed
the
05-05-fix_napi_parser_expose_visitor_keys_files_in_npm_package
branch
from
850bbfb to
87fc903
Compare
graphite-app
bot
force-pushed
the
05-05-ci_benchmarks_estree_benchmark_use_black_box_on_result_of_to_estree_ts_json_
branch
from
2362045 to
33969ac
Compare
Base automatically changed from
05-05-fix_napi_parser_expose_visitor_keys_files_in_npm_package
to
main
May 6, 2025 02:40
graphite-app
bot
deleted the
05-05-ci_benchmarks_estree_benchmark_use_black_box_on_result_of_to_estree_ts_json_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In benchmark for ESTree conversion, pass result of
program.to_estree_ts_json()toblack_box. Without it, if compiler was sufficiently clever, it could remove the entire call toto_estree_ts_jsonbecause the result is never used.