Skip to content

feat(linter/no-extraneous-class): add conditional fixer #10798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
May 9, 2025
Merged

feat(linter/no-extraneous-class): add conditional fixer #10798

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 37 additions & 10 deletions crates/oxc_linter/src/rules/typescript/no_extraneous_class.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,18 +69,17 @@ declare_oxc_lint!(
/// ```
NoExtraneousClass,
typescript,
suspicious
suspicious,
dangerous_suggestion
);

fn empty_class_diagnostic(span: Span, has_decorators: bool) -> OxcDiagnostic {
let diagnostic = OxcDiagnostic::warn("Unexpected empty class.").with_label(span);
if has_decorators {
diagnostic.with_help(
r#"Set "allowWithDecorator": true in your config to allow empty decorated classes"#,
)
let help = if has_decorators {
r#"Set "allowWithDecorator": true in your config to allow empty decorated classes"#
} else {
diagnostic
}
"Delete this class"
};
OxcDiagnostic::warn("Unexpected empty class.").with_label(span).with_help(help)
}

fn only_static_no_extraneous_class_diagnostic(span: Span) -> OxcDiagnostic {
Expand Down Expand Up @@ -147,7 +146,22 @@ impl Rule for NoExtraneousClass {
unsafe { std::hint::assert_unchecked(start <= u32::MAX as usize) };
span = span.shrink_left(start as u32);
}
ctx.diagnostic(empty_class_diagnostic(span, !class.decorators.is_empty()));
let has_decorators = !class.decorators.is_empty();
ctx.diagnostic_with_suggestion(
empty_class_diagnostic(span, has_decorators),
|fixer| {
if has_decorators {
return fixer.noop();
}
if let Some(AstKind::ExportNamedDeclaration(decl)) =
ctx.nodes().parent_kind(node.id())
{
fixer.delete(decl)
} else {
fixer.delete(class)
}
},
);
}
}
[ClassElement::MethodDefinition(constructor)] if constructor.kind.is_constructor() => {
Expand Down Expand Up @@ -308,5 +322,18 @@ fn test() {
("abstract class Foo { constructor() {} }", None),
];

Tester::new(NoExtraneousClass::NAME, NoExtraneousClass::PLUGIN, pass, fail).test_and_snapshot();
let fix = vec![
("class Foo {}", "", None, FixKind::DangerousSuggestion),
("export class Foo {}", "", None, FixKind::DangerousSuggestion),
(
"@foo class Foo {}",
"@foo class Foo {}",
Some(json!([{ "allowWithDecorator": false }])),
FixKind::DangerousSuggestion,
),
];

Tester::new(NoExtraneousClass::NAME, NoExtraneousClass::PLUGIN, pass, fail)
.expect_fix(fix)
.test_and_snapshot();
}
3 changes: 3 additions & 0 deletions crates/oxc_linter/src/snapshots/typescript_no_extraneous_class.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ source: crates/oxc_linter/src/tester.rs
1 │ class Foo {}
· ────────────
╰────
help: Delete this class

⚠ typescript-eslint(no-extraneous-class): Unexpected class with only static properties.
╭─[no_extraneous_class.tsx:5:14]
Expand Down Expand Up @@ -39,6 +40,7 @@ source: crates/oxc_linter/src/tester.rs
· ────────────────────
9 │ }
╰────
help: Delete this class

⚠ typescript-eslint(no-extraneous-class): Unexpected class with only static properties.
╭─[no_extraneous_class.tsx:1:16]
Expand Down Expand Up @@ -79,6 +81,7 @@ source: crates/oxc_linter/src/tester.rs
1 │ abstract class Foo {}
· ─────────────────────
╰────
help: Delete this class

⚠ typescript-eslint(no-extraneous-class): Unexpected class with only static properties.
╭─[no_extraneous_class.tsx:1:16]
Expand Down
Loading