fix(parser): fix panic when the parser tries to re-lex >>

[Boshen]

fixes #10639

[coderabbitai]

Walkthrough

A modification was made to the JavaScript expression parser in the crates/oxc_parser/src/js/expression.rs file. Specifically, within the parse_member_expression_rest method, a check was introduced at the start of the loop to determine if a fatal error has already been recorded (self.fatal_error.is_some()). If such an error exists, the method immediately returns the current left-hand-side expression, halting any further parsing of member expression components. Additionally, a new file named tasks/coverage/misc/fail/oxc-10639.js was added containing a single line with the characters <<Ç and no newline at the end. No changes were made to the signatures of exported or public entities.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0914eaa and 2718f29.

⛔ Files ignored due to path filters (2)

• tasks/coverage/snapshots/parser_misc.snap is excluded by !**/*.snap
• tasks/coverage/snapshots/parser_typescript.snap is excluded by !**/*.snap

📒 Files selected for processing (2)

• crates/oxc_parser/src/js/expression.rs (1 hunks)
• tasks/coverage/misc/fail/oxc-10639.js (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• crates/oxc_parser/src/js/expression.rs

🧰 Additional context used

🪛 Biome (1.9.4)

tasks/coverage/misc/fail/oxc-10639.js

[error] 1-1: Expected a statement but instead found '<<Ç'.

Expected a statement here.

(parse)

⏰ Context from checks skipped due to timeout of 90000ms (3)

• GitHub Check: Miri
• GitHub Check: Benchmark (lexer)
• GitHub Check: Build Linter Benchmark

🔇 Additional comments (1)

tasks/coverage/misc/fail/oxc-10639.js (1)

1-1: Appropriate test case for parser fix.

This test file contains intentionally malformed JavaScript code to test the parser's error handling behavior. The sequence <<Ç is designed to trigger the scenario where the parser previously panicked when encountering and attempting to re-lex certain token sequences. The static analysis error is expected and not an issue since this is intentionally invalid code.

The file follows the project's convention of placing test cases for specific bug fixes in the tasks/coverage/misc/fail directory, with the filename matching the issue number it addresses (oxc-10639).

🧰 Tools

🪛 Biome (1.9.4)

[error] 1-1: Expected a statement but instead found '<<Ç'.

Expected a statement here.

(parse)

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #10756 will not alter performance

_{Comparing 05-01-fix_parser_fix_panic_when_the_parser_tries_to_re-lex_ (2718f29) with main (28ceb90)}

Summary

✅ 36 untouched benchmarks

[Boshen]

Merge activity

• May 1, 10:47 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• May 1, 10:47 AM EDT: Boshen added this pull request to the Graphite merge queue.
• May 1, 11:14 AM EDT: Merged by the Graphite merge queue.