Skip to content

refactor(traverse): remove get_unique_name_impl #10755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
May 1, 2025
Merged

refactor(traverse): remove get_unique_name_impl #10755

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 1 addition & 9 deletions crates/oxc_traverse/src/context/scoping.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -509,14 +509,6 @@ fn get_uid_name_base(name: &str) -> &str {
unsafe { str::from_utf8_unchecked(bytes) }
}

fn get_unique_name<'a>(
base: &str,
uid_names: &FxHashSet<&'a str>,
allocator: &'a Allocator,
) -> ArenaString<'a> {
get_unique_name_impl(base, uid_names, allocator)
}

// TODO: We could make this function more performant, especially when it checks a lot of names
// before it reaches one that is unused.
// This function repeatedly creates strings which have only differ from each other by digits added on end,
Expand All @@ -525,7 +517,7 @@ fn get_unique_name<'a>(
// we could calculate an "unfinished" hash not including the last block, and then just add the final
// block to "finish" the hash on each iteration. With `FxHash` this would be straight line code and only
// a few operations.
fn get_unique_name_impl<'a>(
fn get_unique_name<'a>(
base: &str,
uid_names: &FxHashSet<&'a str>,
allocator: &'a Allocator,
Expand Down
Loading