fix(formatter): do not ignore result of write!

[overlookmotel]

I think this is a bug. Everywhere else in formatter, it looks like the result of write! is passed on to caller if it's Err.

[overlookmotel]

• refactor(ast)!: remove TSMappedTypeModifierOperator::None variant #10749
• fix(formatter): do not ignore result of write! #10750 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[coderabbitai]

Warning

Rate limit exceeded

@graphite-app[bot] has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 7 minutes and 45 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between e5a24c6 and 38b8184.

📒 Files selected for processing (1)

• crates/oxc_formatter/src/write/mod.rs (1 hunks)

Walkthrough

The change updates the implementation of the write method for the TSMappedType type within the formatter module. It specifically modifies the error handling for several write! macro calls that output the readonly modifier strings ("readonly", "+readonly", "-readonly"). By appending the ? operator to these calls, the code now ensures that any formatting errors encountered during these write operations are propagated as FormatResult<()> errors. No other logic, control flow, or public API signatures are affected by this change. The update is limited to internal error handling within the method.

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #10750 will create unknown performance changes

_{Comparing 05-01-fix_formatter_do_not_ignore_result_of_write_ (38b8184) with main (98bcd5f)}

Summary

🆕 36 new benchmarks

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
🆕	codegen[checker.ts]	N/A	22.2 ms	N/A
🆕	codegen_sourcemap[checker.ts]	N/A	65.2 ms	N/A
🆕	formatter[antd.js]	N/A	715.7 ms	N/A
🆕	formatter[react.development.js]	N/A	8.1 ms	N/A
🆕	formatter[typescript.js]	N/A	1.1 s	N/A
🆕	isolated-declarations[vue-id.ts]	N/A	58.3 ms	N/A
🆕	lexer[RadixUIAdoptionSection.jsx]	N/A	21.3 µs	N/A
🆕	lexer[antd.js]	N/A	24.1 ms	N/A
🆕	lexer[cal.com.tsx]	N/A	5.8 ms	N/A
🆕	lexer[checker.ts]	N/A	14.4 ms	N/A
🆕	lexer[pdf.mjs]	N/A	3.9 ms	N/A
🆕	linter[RadixUIAdoptionSection.jsx]	N/A	2.7 ms	N/A
🆕	linter[cal.com.tsx]	N/A	1.2 s	N/A
🆕	linter[checker.ts]	N/A	3.1 s	N/A
🆕	mangler[antd.js]	N/A	15.9 ms	N/A
🆕	mangler[react.development.js]	N/A	294.3 µs	N/A
🆕	mangler[typescript.js]	N/A	39.5 ms	N/A
🆕	minifier[antd.js]	N/A	163.6 ms	N/A
🆕	minifier[react.development.js]	N/A	1.8 ms	N/A
🆕	minifier[typescript.js]	N/A	287.4 ms	N/A
...	...	...	...	...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

[graphite-app]

Merge activity

• May 1, 9:42 AM EDT: Boshen added this pull request to the Graphite merge queue.
• May 1, 2:01 PM UTC: The Graphite merge queue couldn't merge this PR because it failed for an unknown reason.
• May 1, 10:29 AM EDT: Boshen added this pull request to the Graphite merge queue.
• May 1, 11:02 AM EDT: Merged by the Graphite merge queue.