feat(ast_tools): support `#[estree(via)]` on fieldless enum variants by overlookmotel · Pull Request #10746 · oxc-project/oxc

overlookmotel · 2025-05-01T10:46:13Z

Generators for ESTree impls and TS type defs supports #[estree(via = ...)] on enum variants where the variant has a field. Extend this support to fieldless variants too.

#[ast]
#[generate_derive(ESTree)]
enum Foo<'a> {
    // This was already supported
    #[estree(via = FooBar)]
    Bar(Expression<'a>),
    // Add support for this
    #[estree(via = FooQux)]
    Qux,
}

overlookmotel · 2025-05-01T10:46:33Z

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

coderabbitai · 2025-05-01T10:52:50Z

Walkthrough

The changes consist of three main updates across different modules. In the Rust syntax serialization module, four structs—ExportNameNull, ExportImportNameAll, ExportImportNameAllButDefault, and ImportImportNameNamespaceObject—were modified from unit-like structs to tuple structs containing a single unnamed field of type (). In the AST tools derive macros, a new helper function get_converter_path was introduced to centralize and reuse the logic for retrieving the import path of a converter meta type, replacing repeated code in several generator functions. Lastly, in the TypeScript generator, the logic for determining the TypeScript type of enum variants was reordered: the check for a converter (via) now takes precedence over checking for a field type, streamlining the conditional structure. No changes were made to public function signatures except for the addition of the new helper function.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ce26719 and d0ba83c.

⛔ Files ignored due to path filters (1)

crates/oxc_syntax/src/generated/derive_estree.rs is excluded by !**/generated/**

📒 Files selected for processing (3)

crates/oxc_syntax/src/serialize.rs (4 hunks)
tasks/ast_tools/src/derives/estree.rs (3 hunks)
tasks/ast_tools/src/generators/typescript.rs (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (3)

tasks/ast_tools/src/generators/typescript.rs
crates/oxc_syntax/src/serialize.rs
tasks/ast_tools/src/derives/estree.rs

⏰ Context from checks skipped due to timeout of 90000ms (15)

GitHub Check: Benchmark (codegen)
GitHub Check: Benchmark (formatter)
GitHub Check: Benchmark (transformer)
GitHub Check: Benchmark (minifier)
GitHub Check: Benchmark (parser)
GitHub Check: Benchmark (semantic)
GitHub Check: Benchmark (isolated_declarations)
GitHub Check: Benchmark (lexer)
GitHub Check: Build Linter Benchmark
GitHub Check: Conformance
GitHub Check: Clippy
GitHub Check: Test NAPI
GitHub Check: Test wasm32-wasip1-threads
GitHub Check: Test (macos-latest)
GitHub Check: Test (ubuntu-latest)

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codspeed-hq · 2025-05-01T10:55:49Z

CodSpeed Instrumentation Performance Report

Merging #10746 will not alter performance

_{Comparing 05-01-feat_ast_tools_support_estree_via_on_fieldless_enum_variants (d0ba83c) with main (ee79f03)}

Summary

✅ 36 untouched benchmarks

graphite-app · 2025-05-01T11:13:39Z

Merge activity

May 1, 7:13 AM EDT: overlookmotel added this pull request to the Graphite merge queue.
May 1, 7:20 AM EDT: Merged by the Graphite merge queue.

…10746) Generators for `ESTree` impls and TS type defs supports `#[estree(via = ...)]` on enum variants where the variant has a field. Extend this support to fieldless variants too. ```rs #[ast] #[generate_derive(ESTree)] enum Foo<'a> { // This was already supported #[estree(via = FooBar)] Bar(Expression<'a>), // Add support for this #[estree(via = FooQux)] Qux, } ```

…ierOperator` (#10747) Use the support for `#[estree(via = ...)]` on fieldless enum variants added in #10746 to remove custom serializer for `TSMappedTypeModifierOperator`. This serializer can now be auto-generated. Does not effect output, only simplifies how it's generated.

github-actions bot added A-ast-tools Area - AST tools C-enhancement Category - New feature or request labels May 1, 2025

overlookmotel mentioned this pull request May 1, 2025

refactor(ast/estree): remove custom serializer for TSMappedTypeModifierOperator #10747

Merged

overlookmotel marked this pull request as ready for review May 1, 2025 10:50

graphite-app bot added the 0-merge Merge with Graphite Merge Queue label May 1, 2025

graphite-app bot force-pushed the 05-01-feat_ast_tools_support_estree_via_on_fieldless_enum_variants branch from ce26719 to d0ba83c Compare May 1, 2025 11:14

graphite-app bot merged commit d0ba83c into main May 1, 2025
25 checks passed

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label May 1, 2025

graphite-app bot deleted the 05-01-feat_ast_tools_support_estree_via_on_fieldless_enum_variants branch May 1, 2025 11:20

oxc-bot mentioned this pull request May 3, 2025

release(crates): v0.68.0 #10777

Merged

Copilot AI mentioned this pull request Jan 26, 2026

test(linter/no-unused-vars): add tests for generics shadowing namespaces #17930

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(ast_tools): support `#[estree(via)]` on fieldless enum variants#10746

feat(ast_tools): support `#[estree(via)]` on fieldless enum variants#10746
graphite-app[bot] merged 1 commit intomainfrom
05-01-feat_ast_tools_support_estree_via_on_fieldless_enum_variants

overlookmotel commented May 1, 2025 •

edited

Loading

Uh oh!

overlookmotel commented May 1, 2025

Uh oh!

coderabbitai bot commented May 1, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codspeed-hq bot commented May 1, 2025 •

edited

Loading

Uh oh!

graphite-app bot commented May 1, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

overlookmotel commented May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

overlookmotel commented May 1, 2025

How to use the Graphite Merge Queue

Uh oh!

coderabbitai bot commented May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codspeed-hq bot commented May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #10746 will not alter performance

Summary

Uh oh!

graphite-app bot commented May 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

overlookmotel commented May 1, 2025 •

edited

Loading

coderabbitai bot commented May 1, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codspeed-hq bot commented May 1, 2025 •

edited

Loading

graphite-app bot commented May 1, 2025 •

edited

Loading