feat(allocator): implement `Display` for `Box` by overlookmotel · Pull Request #10731 · oxc-project/oxc

overlookmotel · 2025-04-30T20:26:50Z

Implement Display for Box, same as std lib does, by delegating to Display impl for the content of the Box.

overlookmotel · 2025-04-30T20:27:05Z

feat(allocator): implement Display for Box #10731 👈 (View in Graphite)
main

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

0-merge - adds this PR to the back of the merge queue
hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

_{An organization admin has enabled the Graphite Merge Queue in this repository.} _{Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.}

This stack of pull requests is managed by Graphite. Learn more about stacking.

overlookmotel · 2025-04-30T20:31:20Z

Small uncontroversial change, so merging without review.

overlookmotel · 2025-04-30T20:31:41Z

Merge activity

Apr 30, 4:31 PM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
Apr 30, 4:32 PM EDT: overlookmotel added this pull request to the Graphite merge queue.
Apr 30, 4:39 PM EDT: Merged by the Graphite merge queue.

coderabbitai · 2025-04-30T20:33:29Z

Walkthrough

The change introduces an implementation of the Display trait for the Box<'_, T> type, where T is any type that implements the Display trait. This implementation enables formatting of Box<'_, T> instances by delegating the formatting call to the inner value of type T. The Display trait is imported from the standard library's std::fmt module. No other files, logic, or control flow are modified as part of this change.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between ae993dc and d5f66fb.

📒 Files selected for processing (1)

crates/oxc_allocator/src/boxed.rs (2 hunks)

✅ Files skipped from review due to trivial changes (1)

crates/oxc_allocator/src/boxed.rs

⏰ Context from checks skipped due to timeout of 90000ms (16)

GitHub Check: Conformance
GitHub Check: Test NAPI
GitHub Check: Clippy
GitHub Check: Test wasm32-wasip1-threads
GitHub Check: Test (macos-latest)
GitHub Check: Test (ubuntu-latest)
GitHub Check: Benchmark (formatter)
GitHub Check: Benchmark (transformer)
GitHub Check: Benchmark (lexer)
GitHub Check: Benchmark (isolated_declarations)
GitHub Check: Benchmark (codegen)
GitHub Check: Benchmark (minifier)
GitHub Check: Benchmark (parser)
GitHub Check: Benchmark (semantic)
GitHub Check: Build Linter Benchmark
GitHub Check: Miri

✨ Finishing Touches

📝 Generate Docstrings

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

coderabbitai

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c9575f6 and ae993dc.

📒 Files selected for processing (1)

crates/oxc_allocator/src/boxed.rs (2 hunks)

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: Benchmark linter (0)

🔇 Additional comments (1)

crates/oxc_allocator/src/boxed.rs (1)

7-7: Import Display trait alongside Formatter correctly
The addition of Display (and Formatter) to the use std::fmt import brings exactly what you need for the new Display implementation without extra baggage. This aligns with existing imports and keeps the module tidy.

crates/oxc_allocator/src/boxed.rs

Implement `Display` for `Box`, same as std lib does, by delegating to `Display` impl for the content of the `Box`.

codspeed-hq · 2025-04-30T20:33:48Z

CodSpeed Instrumentation Performance Report

Merging #10731 will not alter performance

_{Comparing 04-30-feat_allocator_implement_display_for_box_ (d5f66fb) with main (c9575f6)}

Summary

✅ 36 untouched benchmarks

github-actions bot added the C-enhancement Category - New feature or request label Apr 30, 2025

overlookmotel marked this pull request as ready for review April 30, 2025 20:31

overlookmotel added the 0-merge Merge with Graphite Merge Queue label Apr 30, 2025

coderabbitai bot reviewed Apr 30, 2025

View reviewed changes

crates/oxc_allocator/src/boxed.rs Show resolved Hide resolved

feat(allocator): implement Display for Box (#10731)

d5f66fb

Implement `Display` for `Box`, same as std lib does, by delegating to `Display` impl for the content of the `Box`.

graphite-app bot force-pushed the 04-30-feat_allocator_implement_display_for_box_ branch from ae993dc to d5f66fb Compare April 30, 2025 20:33

graphite-app bot merged commit d5f66fb into main Apr 30, 2025
26 checks passed

graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 30, 2025

graphite-app bot deleted the 04-30-feat_allocator_implement_display_for_box_ branch April 30, 2025 20:39

oxc-bot mentioned this pull request May 3, 2025

release(crates): v0.68.0 #10777

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

feat(allocator): implement `Display` for `Box`#10731

feat(allocator): implement `Display` for `Box`#10731
graphite-app[bot] merged 1 commit intomainfrom
04-30-feat_allocator_implement_display_for_box_

overlookmotel commented Apr 30, 2025 •

edited

Loading

Uh oh!

overlookmotel commented Apr 30, 2025

Uh oh!

overlookmotel commented Apr 30, 2025

Uh oh!

overlookmotel commented Apr 30, 2025 •

edited by graphite-app bot

Loading

Uh oh!

coderabbitai bot commented Apr 30, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Uh oh!

Uh oh!

codspeed-hq bot commented Apr 30, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

overlookmotel commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

overlookmotel commented Apr 30, 2025

How to use the Graphite Merge Queue

Uh oh!

overlookmotel commented Apr 30, 2025

Uh oh!

overlookmotel commented Apr 30, 2025 • edited by graphite-app bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge activity

Uh oh!

coderabbitai bot commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

codspeed-hq bot commented Apr 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CodSpeed Instrumentation Performance Report

Merging #10731 will not alter performance

Summary

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

overlookmotel commented Apr 30, 2025 •

edited

Loading

overlookmotel commented Apr 30, 2025 •

edited by graphite-app bot

Loading

coderabbitai bot commented Apr 30, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codspeed-hq bot commented Apr 30, 2025 •

edited

Loading