Skip to content

style(ast): import Display trait#10724

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-30-style_ast_import_display_trait
Apr 30, 2025
Merged

style(ast): import Display trait#10724
graphite-app[bot] merged 1 commit intomainfrom
04-30-style_ast_import_display_trait

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Apr 30, 2025

Purely stylistic change. Import Display trait to avoid repeated impl fmt::Display for ... throughout the rest of the file. Personally I think for standard traits like Display and Debug, this is clearer.

Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions github-actions bot added A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior labels Apr 30, 2025
@overlookmotel overlookmotel marked this pull request as ready for review April 30, 2025 13:46
@overlookmotel
Copy link
Member Author

Stylistic change only, so merging without review.

@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Apr 30, 2025
Copy link
Member Author

overlookmotel commented Apr 30, 2025

Merge activity

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 30, 2025

CodSpeed Instrumentation Performance Report

Merging #10724 will not alter performance

Comparing 04-30-style_ast_import_display_trait (c18c81f) with main (8bfd5e3)

Summary

✅ 30 untouched benchmarks
🆕 6 new benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
🆕 isolated-declarations[vue-id.ts] N/A 58.5 ms N/A
🆕 lexer[RadixUIAdoptionSection.jsx] N/A 21.1 µs N/A
🆕 lexer[antd.js] N/A 24.1 ms N/A
🆕 lexer[cal.com.tsx] N/A 5.8 ms N/A
🆕 lexer[checker.ts] N/A 14.4 ms N/A
🆕 lexer[pdf.mjs] N/A 3.9 ms N/A

Purely stylistic change. Import `Display` trait to avoid repeated `impl fmt::Display for ...` throughout the rest of the file. Personally I think for standard traits like `Display` and `Debug`, this is clearer.
@graphite-app graphite-app bot force-pushed the 04-30-style_ast_import_display_trait branch from c0b8d37 to c18c81f Compare April 30, 2025 14:03
@graphite-app graphite-app bot merged commit c18c81f into main Apr 30, 2025
25 checks passed
@graphite-app graphite-app bot deleted the 04-30-style_ast_import_display_trait branch April 30, 2025 14:09
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-cleanup Category - technical debt or refactoring. Solution not expected to change behavior

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant