refactor(transformer/refresh): shorten code

[overlookmotel]

Pure refactor. Shorten code a little by using AstBuilder methods which create an Expression directly.

[overlookmotel]

• refactor(transformer/refresh): shorten code #10718 👈 (View in Graphite)
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[overlookmotel]

Tiny change, and refactor only, so merging without review.

[overlookmotel]

Merge activity

• Apr 30, 7:17 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Apr 30, 7:25 AM EDT: overlookmotel added this pull request to the Graphite merge queue.
• Apr 30, 11:46 AM UTC: The Graphite merge queue couldn't merge this PR because it timed out.
• Apr 30, 9:30 AM EDT: The merge label '0-merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
• Apr 30, 10:18 AM EDT: overlookmotel added this pull request to the Graphite merge queue.
• Apr 30, 10:39 AM EDT: Merged by the Graphite merge queue.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #10718 will not alter performance

_{Comparing 04-29-refactor_transformer_refresh_shorten_code (62843e6) with main (7234ba4)}

Summary

✅ 36 untouched benchmarks

[coderabbitai]

Walkthrough

The update refactors the way identifier expressions are constructed within the RefreshIdentifierResolver::to_expression method in the refresh.rs module. It replaces the use of ctx.ast.alloc_identifier_reference_with_reference_id wrapped in Expression::Identifier with a direct call to ctx.ast.expression_identifier_with_reference_id, which returns an Expression directly. This change is applied in two locations within the method, affecting both simple identifiers and member expression object identifiers. The overall logic and control flow of the method remain unchanged.

Changes

File(s)	Change Summary
crates/oxc_transformer/src/jsx/refresh.rs	Refactored identifier expression construction to use expression_identifier_with_reference_id directly instead of wrapping alloc_identifier_reference_with_reference_id in Expression::Identifier. No logic or control flow changes.

Poem

A rabbit hopped through code so neat,
Swapping wrappers for a simpler treat.
Expressions now, direct and clear,
No extra layers hiding here.
With every hop, the AST grew light—
Refactored fields, a coder's delight!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between efb5e32 and 62843e6.

📒 Files selected for processing (1)

• crates/oxc_transformer/src/jsx/refresh.rs (1 hunks)

✅ Files skipped from review due to trivial changes (1)

• crates/oxc_transformer/src/jsx/refresh.rs

⏰ Context from checks skipped due to timeout of 90000ms (15)

• GitHub Check: Benchmark (formatter)
• GitHub Check: Benchmark (semantic)
• GitHub Check: Benchmark (transformer)
• GitHub Check: Benchmark (minifier)
• GitHub Check: Benchmark (isolated_declarations)
• GitHub Check: Benchmark (codegen)
• GitHub Check: Benchmark (lexer)
• GitHub Check: Benchmark (parser)
• GitHub Check: Build Linter Benchmark
• GitHub Check: Conformance
• GitHub Check: Clippy
• GitHub Check: Test NAPI
• GitHub Check: Test (ubuntu-latest)
• GitHub Check: Test (macos-latest)
• GitHub Check: Test wasm32-wasip1-threads

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[overlookmotel]

The update refactors the way identifier expressions are constructed within the RefreshIdentifierResolver::to_expression method in the refresh.rs module. It replaces the use of ctx.ast.alloc_identifier_reference_with_reference_id wrapped in Expression::Identifier with a direct call to ctx.ast.expression_identifier_with_reference_id, which returns an Expression directly. This change is applied in two locations within the method, affecting both simple identifiers and member expression object identifiers. The overall logic and control flow of the method remain unchanged.

Who's this dude?!

His description of the PR is longer than the diff!