fix(estree): Adjust span for TSTypePredicate.typeAnnotation

[leaysgur]

Part of #9705

Given code like this:

function f(v): v is (1|2) {}

Currently, TSTypePredicate.type_annotation.span contains positions for ( and ), but it should not when preserveParens: false for TS-ESTree.

https://playground.oxc.rs/#eNptj01vgzAMhv8KyqmVkAp03QfnqddN25VLCKaKFBxkJ2wV478vKR/bob7EVl4/ft9RKFGK1qNy2mLS7oZ9mQyJ5mSX/xT7ZJwqPByK48Pp8en5JcvvdFGQLZVvVWx1rLBCkQorylGQx/jwFZ38FqUjD6kwGp0oW2k4DKxsD+sPX7vamnVyJJFbS90inlLRS2KgiJTG2K8PcJ7wzTvWDZyXVOt6TxC0A7xLAuQ/Rjx/Y4R+OzFDnaQLBG8CuMjyU0ih2RrpoHkFZSTJyP+HUraBC9wiAsrawKf1pKCT/WwiSDqNutXrPWXRkTXn4D0uDUC15RB/Bk7TL/T+ijY=

---

BTW, TypePredicate.type_annotation should be just TSType instead of TSTypeAnnotation(And generate extra TSTypeAnnotation for TS-ESTree)?

oxc/crates/oxc_ast/src/ast/ts.rs

Lines 1123 to 1135 in 7d8efd8

	pub struct TSTypePredicate<'a> {
	pub span: Span,
	/// The identifier the predicate operates on
	pub parameter_name: TSTypePredicateName<'a>,
	/// Does this predicate include an `asserts` modifier?
	///
	/// ## Example
	/// ```ts
	/// declare function isString(x: any): asserts x is string; // true
	/// ```
	pub asserts: bool,
	pub type_annotation: Option<Box<'a, TSTypeAnnotation<'a>>>,
	}

[graphite-app]

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #10711 will not alter performance

_{Comparing fix/typepredicate_span2 (0b35b3e) with main (7d8efd8)}

Summary

✅ 33 untouched benchmarks
🆕 3 new benchmarks

Benchmarks breakdown

	Benchmark	BASE	HEAD	Change
🆕	linter[RadixUIAdoptionSection.jsx]	N/A	2.7 ms	N/A
🆕	linter[cal.com.tsx]	N/A	1.2 s	N/A
🆕	linter[checker.ts]	N/A	3.1 s	N/A

[Boshen]

BTW, TypePredicate.type_annotation should be just TSType instead of TSTypeAnnotation(And generate extra TSTypeAnnotation for TS-ESTree)?

Probably.

[graphite-app]

Merge activity

• Apr 30, 10:08 AM UTC: @leaysgur we removed the merge queue label because we could not find a Graphite account associated with your GitHub profile.

You must have a Graphite account in order to use the merge queue. Create an account and try again using this link