Skip to content

fix(ast/estree): rename assert to with in TSImportType options in TS-ESTree AST#10681

Merged
graphite-app[bot] merged 1 commit intomainfrom
04-28-fix_ast_estree_rename_assert_to_with_in_tsimporttype_options_in_ts-estree_ast
Apr 28, 2025
Merged

fix(ast/estree): rename assert to with in TSImportType options in TS-ESTree AST#10681
graphite-app[bot] merged 1 commit intomainfrom
04-28-fix_ast_estree_rename_assert_to_with_in_tsimporttype_options_in_ts-estree_ast

Conversation

@overlookmotel
Copy link
Member

@overlookmotel overlookmotel commented Apr 28, 2025

TS-ESLint parser replaces a property of options called assert with one called with.

typescript-eslint/typescript-eslint#11114

This looks like it's an error on their side, but in the meantime replicate this behavior.

@github-actions github-actions bot added A-ast Area - AST C-bug Category - Bug labels Apr 28, 2025
Copy link
Member Author


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@overlookmotel overlookmotel marked this pull request as ready for review April 28, 2025 18:41
@overlookmotel overlookmotel added the 0-merge Merge with Graphite Merge Queue label Apr 28, 2025
Copy link
Member Author

overlookmotel commented Apr 28, 2025

Merge activity

@codspeed-hq
Copy link

codspeed-hq bot commented Apr 28, 2025

CodSpeed Instrumentation Performance Report

Merging #10681 will not alter performance

Comparing 04-28-fix_ast_estree_rename_assert_to_with_in_tsimporttype_options_in_ts-estree_ast (61d825b) with main (432cd77)

Summary

✅ 36 untouched benchmarks

…` in TS-ESTree AST (#10681)

TS-ESLint parser replaces a property of `options` called `assert` with one called `with`.

typescript-eslint/typescript-eslint#11114

This looks like it's an error on their side, but in the meantime replicate this behavior.
@graphite-app graphite-app bot force-pushed the 04-28-fix_ast_estree_rename_assert_to_with_in_tsimporttype_options_in_ts-estree_ast branch from fea8cca to 61d825b Compare April 28, 2025 18:48
@graphite-app graphite-app bot merged commit 61d825b into main Apr 28, 2025
25 checks passed
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Apr 28, 2025
@graphite-app graphite-app bot deleted the 04-28-fix_ast_estree_rename_assert_to_with_in_tsimporttype_options_in_ts-estree_ast branch April 28, 2025 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-ast Area - AST C-bug Category - Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant