perf(parser): faster parsing TemplateElements#10678
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 28, 2025
Merged
Conversation
github-actions
bot
added
A-parser
overlookmotel
force-pushed
the
04-28-perf_parser_faster_parsing_templateelement_s
branch
from
1a769a3 to
6213662
Compare
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
overlookmotel
force-pushed
the
04-28-perf_parser_faster_parsing_templateelement_s
branch
from
6213662 to
4349224
Compare
CodSpeed Instrumentation Performance ReportMerging #10678 will not alter performanceComparing Summary
|
Member
Merge activity
|
Speed up parsing `TemplateElement` a little by: * Only slice source text once to get `raw` (rather than slicing a slice). * Fast path for when `TemplateElement` contains no escapes: * Don't slice source text again to get `cooked` - just copy the existing `Atom` for `raw`. * Don't search for `\r` in `raw` - it can't be there because otherwise `escaped` would be `true`. This also allows removing some code repetition.
graphite-app
bot
force-pushed
the
04-28-perf_parser_faster_parsing_templateelement_s
branch
from
4349224 to
4861a62
Compare
graphite-app
bot
deleted the
04-28-perf_parser_faster_parsing_templateelement_s
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speed up parsing
TemplateElementa little by:raw(rather than slicing a slice).TemplateElementcontains no escapes:cooked- just copy the existingAtomforraw.\rinraw- it can't be there because otherwiseescapedwould betrue.This also allows removing some code repetition.