refactor(ast/estree): convert_utf8_to_utf16 take &mut slice of errors, not &mut Vec#10672
Merged
graphite-app[bot] merged 1 commit intomainfrom Apr 28, 2025
Conversation
Member
Author
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 28, 2025
github-actions
bot
added
the
C-cleanup
Member
Author
|
Small change, and uncontroversial, so merging without review. |
Member
Author
Merge activity
|
CodSpeed Instrumentation Performance ReportMerging #10672 will not alter performanceComparing Summary
|
…rors, not `&mut Vec` (#10672) Pure refactor. `convert_utf8_to_utf16` doesn't need to take a `&mut Vec<OxcError>`. `&mut [OxcError]` is sufficient, and the extra indirection of `&mut Vec` is not ideal.
graphite-app
bot
force-pushed
the
04-28-refactor_ast_estree_convert_utf8_to_utf16_take_mut_slice_of_errors_not_mut_vec_
branch
from
0dfe514 to
06fde2a
Compare
graphite-app
bot
deleted the
04-28-refactor_ast_estree_convert_utf8_to_utf16_take_mut_slice_of_errors_not_mut_vec_
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pure refactor.
convert_utf8_to_utf16doesn't need to take a&mut Vec<OxcError>.&mut [OxcError]is sufficient, and the extra indirection of&mut Vecis not ideal.