Skip to content

fix(linter): false positive in eslint/curly on windows #10671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Apr 28, 2025
Merged

fix(linter): false positive in eslint/curly on windows #10671

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 30 additions & 2 deletions crates/oxc_linter/src/rules/eslint/curly.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -391,8 +391,16 @@ fn is_lexical_declaration(node: &Statement) -> bool {

#[expect(clippy::cast_possible_truncation)]
fn get_next_char_offset(span: Span, ctx: &LintContext) -> Option<u32> {
let next_char = ctx.source_text()[(span.end as usize)..].chars().next();
next_char.map(|c| span.end + c.len_utf8() as u32)
let src = ctx.source_text();
let start = span.end as usize;

if let Some(tail) = src.get(start..) {
if tail.starts_with("\r\n") || tail.starts_with("\n\r") {
return Some(span.end + 2);
}
}

src[start..].chars().next().map(|c| span.end + c.len_utf8() as u32)
}

#[expect(clippy::cast_possible_truncation)] // for `as i32`
Expand Down Expand Up @@ -801,6 +809,26 @@ fn test() {
"if (a) while (cond) for (;;) for (key in obj) { if (b) foo(); } else bar();",
Some(serde_json::json!(["multi"])),
),
(
" const isIterable = (obj: any) : obj is Iterable<IgnoreRule> => {
if (obj === null) return false;
else if (typeof obj === 'string') return false;
else return typeof value[Symbol.iterator] === 'function';
};",
Some(serde_json::json!(["multi"])),
),
(
"const isIterable = (obj: any): obj is Iterable<IgnoreRule> => {\r\n if (obj === null) return false;\r\n else if (typeof obj === 'string') return false;\r\n else return typeof value[Symbol.iterator] === 'function';\r\n};\r\n",
Some(serde_json::json!(["multi-line"])),
),
(
" const isIterable = (obj: any) : obj is Iterable<IgnoreRule> => {
if (obj === null) return false;
else if (typeof obj === 'string') return false;
else return typeof value[Symbol.iterator] === 'function';
};",
Some(serde_json::json!(["multi"])),
),
];

let fail = vec![
Expand Down
Loading