feat(allocator/vec2): introduce extend_desugared method as extend internal implementation

[Dunqing]

Align extend implementation with the standard library, since the ExtendTrusted is still unstable, so I haven't introduced the extend_trusted yet. Some of the benchmark performance regression has been almost fixed in #10675.

[Dunqing]

• perf(allocator/vec2): align min amortized cap size with std #9857
• feat(allocator/vec2): align RawVec::reserve with standard library implementation #10701
• perf(allocator/vec2): replace self.reserve(1) calls with self.grow_one() for better efficiency #9856
• feat(allocator/vec2): add specialized grow_one method #9855
• perf(allocator/vec2): calling Bump::grow or Bump::shrink at the call site directly instead of calling realloc #10686
• perf(allocator/vec2): resolve performance regression for extend by marking reserve as #[cold] and #[inline(never)] #10675
• feat(allocator/vec2): introduce extend_desugared method as extend internal implementation #10670 👈 (View in Graphite)
• perf(transformer/refresh): use take/take_in instead of drain #10656
• perf(transformer): optimize inserting var/let statements #10654
• main

---

How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

• 0-merge - adds this PR to the back of the merge queue
• hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

[codspeed-hq]

CodSpeed Instrumentation Performance Report

Merging #10670 will not alter performance

_{Comparing 04-28-feat_allocator_vec2_introduce_extend_desugared_method_as_extend_internal_implementation (6ce3bbb) with main (eb3f37c)}

Summary

✅ 36 untouched benchmarks

[graphite-app]

Merge activity

• May 3, 9:02 AM EDT: Boshen added this pull request to the Graphite merge queue.
• May 3, 9:09 AM EDT: Merged by the Graphite merge queue.

[coderabbitai]

Walkthrough

The implementation of the Extend<T> trait for the Vec<'bump, T> type in the crates/oxc_allocator/src/vec2/mod.rs file was refactored. The logic for extending the vector is now delegated to a new private method named extend_desugared. This new method iterates over the input iterator and, for each element, checks if the vector has reached its capacity. If the capacity is reached, it reserves additional space based on the iterator's lower size hint plus one. Elements are written directly into the buffer using unsafe pointer operations, and the vector's length is incremented after each insertion. The method is annotated with #[track_caller] and is intended to serve as the core implementation for extension operations. The public extend method now calls this new private method. No changes were made to the public API surface apart from the internal delegation.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9db9639 and 6ce3bbb.

📒 Files selected for processing (1)

• crates/oxc_allocator/src/vec2/mod.rs (1 hunks)

🚧 Files skipped from review as they are similar to previous changes (1)

• crates/oxc_allocator/src/vec2/mod.rs

⏰ Context from checks skipped due to timeout of 90000ms (16)

• GitHub Check: Benchmark (formatter)
• GitHub Check: Benchmark (codegen)
• GitHub Check: Benchmark (minifier)
• GitHub Check: Benchmark (semantic)
• GitHub Check: Test wasm32-wasip1-threads
• GitHub Check: Test (macos-latest)
• GitHub Check: Benchmark (isolated_declarations)
• GitHub Check: Benchmark (transformer)
• GitHub Check: Test NAPI
• GitHub Check: Test (ubuntu-latest)
• GitHub Check: Benchmark (parser)
• GitHub Check: Build Linter Benchmark
• GitHub Check: Clippy
• GitHub Check: Conformance
• GitHub Check: Benchmark (lexer)
• GitHub Check: Miri

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.