Skip to content

fix(linter): false positive in typescript/explicit-function-return-type with satisfies #10668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
graphite-app merged 1 commit into from
Apr 29, 2025
Merged

fix(linter): false positive in typescript/explicit-function-return-type with satisfies #10668

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
66 changes: 62 additions & 4 deletions crates/oxc_linter/src/rules/typescript/explicit_function_return_type.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -420,6 +420,14 @@ impl ExplicitFunctionReturnType {
let AstKind::ArrowFunctionExpression(func) = node.kind() else { return false };
let Some(expr) = func.get_expression() else { return false };

let mut expr = expr;
loop {
expr = match expr {
Expression::TSSatisfiesExpression(e) => &e.expression,
_ => break,
};
}

match expr {
Expression::TSAsExpression(ts_expr) => {
let TSType::TSTypeReference(ts_type) = &ts_expr.type_annotation else {
Expand Down Expand Up @@ -606,7 +614,10 @@ fn is_typed_jsx(node: &AstNode) -> bool {
}

fn is_function(expr: &Expression) -> bool {
matches!(expr, Expression::ArrowFunctionExpression(_) | Expression::FunctionExpression(_))
matches!(
expr.get_inner_expression(),
Expression::ArrowFunctionExpression(_) | Expression::FunctionExpression(_)
)
}

fn ancestor_has_return_type<'a>(node: &AstNode<'a>, ctx: &LintContext<'a>) -> bool {
Expand Down Expand Up @@ -1145,9 +1156,56 @@ fn test() {
),
(
"
new Promise(resolve => {});
new Foo(1, () => {});
",
interface R {
type: string;
value: number;
}

const func = (value: number) => ({ type: 'X', value }) as const satisfies R;
",
Some(
serde_json::json!([ { "allowDirectConstAssertionInArrowFunctions": true, }, ]),
),
None,
None,
),
(
"
interface R {
type: string;
value: number;
}

const func = (value: number) =>
({ type: 'X', value }) as const satisfies R satisfies R;
",
Some(
serde_json::json!([ { "allowDirectConstAssertionInArrowFunctions": true, }, ]),
),
None,
None,
),
(
"
interface R {
type: string;
value: number;
}

const func = (value: number) =>
({ type: 'X', value }) as const satisfies R satisfies R satisfies R;
",
Some(
serde_json::json!([ { "allowDirectConstAssertionInArrowFunctions": true, }, ]),
),
None,
None,
),
(
"
new Promise(resolve => {});
new Foo(1, () => {});
",
Some(serde_json::json!([ { "allowTypedFunctionExpressions": true, }, ])),
None,
None,
Expand Down
Loading